Skip to contentSkip to conversation

Documentation/git-send-email.txt: Mention less secure app access might need to enable.

PATCH In review Vasyl Vavrychuk 4 participants 9 messages Aug 17, 2020 – Jan 7, 2021 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Looks like Google changed gmail security and now less secure app access needs to be explicitly enabled if 2-factor authentication is not in place, otherwise send-mail fails with:

5.7.8 Username and Password not accepted. Learn more at
5.7.8 https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp

---
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Documentation/git-send-email.txt +5 -1
index 0a69810147..5aed3f5b1d 100644
@@ -494,6 +494,10 @@ edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
+If you do not have multifactor authentication setup on your gmail account, you
+need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
 If you have multifactor authentication setup on your gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.
@@ -505,7 +509,7 @@ following commands:
 	$ edit outgoing/0000-*
 	$ git send-email outgoing/*
 
-The first time you run it, you will be prompted for your credentials.  Enter the
+The first time you run it, you will be prompted for your credentials. Enter the
 app-specific or your regular password as appropriate.  If you have credential
 helper configured (see linkgit:git-credential[1]), the password will be saved in
 the credential store so you won't have to type it the next time.
Signature · 1 line
2.23.0
#1 lore raw
Quoted 7 lines · Vasyl Vavrychuk

Looks like Google changed gmail security and now less secure app access needs to be explicitly enabled if 2-factor authentication is not in place, otherwise send-mail fails with:

5.7.8 Username and Password not accepted. Learn more at
5.7.8 https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp
---

Missing sign-off. Please see Documentation/SubmittingPatches.

Documentation/git-send-email.txt edit ~/.gitconfig to specify your account settings: · line 496

Quoted 5 lines
Documentation/git-send-email.txt +3 -0
@@ -494,6 +494,10 @@ edit ~/.gitconfig to specify your account settings:
+If you do not have multifactor authentication setup on your gmail account, you
+need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.

Thanks. Make sense. A few comments:

I think multi-factor is usually hyphenated, so perhaps:
s/multifactor/multi-factor/

Since you are not using it as a noun: s/setup/set up/

Also, Gmail is normally capitalized, so: s/gmail/Gmail

Documentation/git-send-email.txt following commands: · line 509

Quoted 3 lines
Documentation/git-send-email.txt +1 -1
@@ -505,7 +509,7 @@ following commands:
-The first time you run it, you will be prompted for your credentials.  Enter the
+The first time you run it, you will be prompted for your credentials. Enter the

This unnecessary whitespace change just adds noise to the patch, thus should be dropped.

#2 lore raw

PATCH 1/1 Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Looks like Google changed Gmail security and now less secure app access needs to be explicitly enabled if 2-factor authentication is not in place, otherwise send-mail fails with:

5.7.8 Username and Password not accepted. Learn more at
5.7.8 https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp

---
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Documentation/git-send-email.txt +5 -1
index 0a69810147..06953fd1e0 100644
@@ -494,7 +494,11 @@ edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
-If you have multifactor authentication setup on your gmail account, you will
+If you do not have multi-factor authentication set up on your Gmail account, you
+will need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
+If you have multi-factor authentication set up on your Gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.
 
Signature · 1 line
2.23.0
#3 lore raw
Quoted 3 lines · Vasyl Vavrychuk

Looks like Google changed Gmail security and now less secure app access needs to be explicitly enabled if 2-factor authentication is not in place, otherwise send-mail fails with:

'send-email' I presume?

Quoted 2 lines

5.7.8 Username and Password not accepted. Learn more at
5.7.8 https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp

Is the v5sm1375... part stay constant that everybody would get the same thing?

Otherwise,

... otherwise send-email fails with an error message from Gmail server telling the user to "Learn more" at
https://support.google.com/mail/?p=BadCredentials

would be preferrable.

Quoted 11 lines
---
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Documentation/git-send-email.txt +0 -0
index 0a69810147..06953fd1e0 100644
@@ -494,7 +494,11 @@ edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587

Documentation/git-send-email.txt edit ~/.gitconfig to specify your account settings: · line 503

Quoted 10 lines
Documentation/git-send-email.txt +5 -1
 ----
 
-If you have multifactor authentication setup on your gmail account, you will
+If you do not have multi-factor authentication set up on your Gmail account, you
+will need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
+If you have multi-factor authentication set up on your Gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.

In 2020, we should probably list the instruction for those with 2 factor first and then give "less secure app access" as a fallback. IOW, I'd suggest the order of these two paragraphs swapped.

Thanks.

#4 lore raw
Quoted 1 line · Junio C Hamano

Vasyl Vavrychuk <[email protected]> writes:

Another thing I forgot to say.

Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Especially with grammofix s/to enable/to be enabled/ applied, the above is way too long as a title and would stand out like a sore thumb in "git shortlog --no-merges v2.28.0..v2.29.0" output. Something like

Subject: [PATCH] send-email doc: mention less secure app access with GMail

perhaps.

Thanks.

#5 lore raw
Quoted 13 lines · Junio C Hamano
Quoted 1 line · Junio C Hamano

Vasyl Vavrychuk <[email protected]> writes:

Another thing I forgot to say.

Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Especially with grammofix s/to enable/to be enabled/ applied, the above is way too long as a title and would stand out like a sore thumb in "git shortlog --no-merges v2.28.0..v2.29.0" output. Something like

Quoted 5 lines

Subject: [PATCH] send-email doc: mention less secure app access with GMail

perhaps.

Thanks.

Anything new on this topic? No rush, but I'd hate to see a basically good topic to be left in the stalled state too long.

#6 lore raw
Quoted 15 lines · Junio C Hamano
Quoted 13 lines · Junio C Hamano
Quoted 1 line · Junio C Hamano

Vasyl Vavrychuk <[email protected]> writes:

Another thing I forgot to say.

Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Especially with grammofix s/to enable/to be enabled/ applied, the above is way too long as a title and would stand out like a sore thumb in "git shortlog --no-merges v2.28.0..v2.29.0" output. Something like

Quoted 8 lines
Quoted 5 lines

Subject: [PATCH] send-email doc: mention less secure app access with GMail

perhaps.

Thanks.

Anything new on this topic? No rush, but I'd hate to see a basically good topic to be left in the stalled state too long.

Just pinging old threads that we have been expecting a reroll, but it has been more than 3 months. Has an update been sent that I missed?

Thanks.

#7 lore raw

PATCH v3 1/1 git-send-email.txt: mention less secure app access with Gmail

In reply to Vasyl Vavrychuk

Google may have changed Gmail security and now less secure app access needs to be explicitly enabled if two-factor authentication is not in place, otherwise send-email fails with:

5.7.8 Username and Password not accepted. Learn more at 5.7.8 https://support.google.com/mail/?p=BadCredentials

Document steps required to make this work.

---
Range-diff against v2:

1:  2bcfd1403f < -:  ---------- Documentation/git-send-email.txt: Mention less secure app access might need to enable.
-:  ---------- > 1:  274475559a git-send-email.txt: mention less secure app access with Gmail
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Documentation/git-send-email.txt +5 -1
index 0a69810147..0db0783f2f 100644
@@ -494,10 +494,14 @@ edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
-If you have multifactor authentication setup on your gmail account, you will
+If you have multi-factor authentication set up on your Gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.
 
+If you do not have multi-factor authentication set up on your Gmail account,
+you will need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
 Once your commits are ready to be sent to the mailing list, run the
 following commands:
 
Signature · 1 line
2.30.0
#8 lore raw

Re: [PATCH v3] git-send-email.txt: mention less secure app access with Gmail

Quoted 11 lines · Denton Liu

Google may have changed Gmail security and now less secure app access needs to be explicitly enabled if two-factor authentication is not in place, otherwise send-email fails with:

5.7.8 Username and Password not accepted. Learn more at 5.7.8 https://support.google.com/mail/?p=BadCredentials

Document steps required to make this work.

Thanks for picking this up.

Has this version changed in any substantial way from Vasyl's v2[1]? If not, perhaps it makes sense to retain his authorship and sign-off.

[1]: https://lore.kernel.org/git/[email protected]/