Skip to contentSkip to conversation

SubmittingPatches: tighten wording on "sign-off" procedure

PATCH Superseded Junio C Hamano 3 participants 5 messages Dec 28, 2020 – Jan 7, 2021 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SubmittingPatches: tighten wording on "sign-off" procedure

The text says "if you can certify DCO then you add a Singed-off-by trailer". But it does not say anything about people who cannot certify. A natural reading may be that if you cannot certify, you do not add the trailer, but it shouldn't hurt to be overly explicit.

---

 Documentation/SubmittingPatches | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/SubmittingPatches +1 -1
index d12094bac5..b091730771 100644
@@ -307,35 +307,35 @@ wrote the patch or have the right to pass it on under the same license
 as ours, by "signing off" your patch.  Without sign-off, we cannot
 accept your patches.
 
-If you can certify the below D-C-O:
+If (and only if) you can certify the below D-C-O:
 
 [[dco]]
 .Developer's Certificate of Origin 1.1
 ____
 By making a contribution to this project, I certify that:
 
 a. The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or
 
 b. The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or
 
 c. The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.
 
 d. I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
 ____
 
 you add a "Signed-off-by" trailer to your commit, that looks like
 this:
#1 lore raw
Quoted 4 lines · Junio C Hamano

The text says "if you can certify DCO then you add a Singed-off-by trailer". But it does not say anything about people who cannot certify. A natural reading may be that if you cannot certify, you do not add the trailer, but it shouldn't hurt to be overly explicit.

It doesn't matter if a person *can* certify, what matters is if the person *does* certify.

In a weeding ceremony when asked "do you take this woman to be your wife?", the answer that is looked for is not "I can".

Do you or don't you? Is the question.

Documentation/SubmittingPatches wrote the patch or have the right to pass it on under the same license · line 310

Quoted 10 lines
Documentation/SubmittingPatches +1 -1
index d12094bac5..b091730771 100644
@@ -307,35 +307,35 @@ wrote the patch or have the right to pass it on under the same license
 as ours, by "signing off" your patch.  Without sign-off, we cannot
 accept your patches.
 
-If you can certify the below D-C-O:
+If (and only if) you can certify the below D-C-O:

If you certify the bellow D-C-O:

Quoted 3 lines
Documentation/SubmittingPatches +0 -0
 [[dco]]
 .Developer's Certificate of Origin 1.1
 ____
Signature · 1 line
Felipe Contreras
#2 lore raw
Quoted 4 lines · Felipe Contreras

Documentation/SubmittingPatches wrote the patch or have the right to pass it on under the same license · line 310

Quoted 2 lines
Documentation/SubmittingPatches +1 -1
-If you can certify the below D-C-O:
+If (and only if) you can certify the below D-C-O:

If you certify the bellow D-C-O:

Yes, dropping "can" would be a good clarification, I would think, too.

Quoted 4 lines
Quoted 4 lines

[[dco]]
.Developer's Certificate of Origin 1.1
____

#3 lore raw
In reply to Junio C Hamano
Quoted 4 lines · Junio C Hamano

The text says "if you can certify DCO then you add a Singed-off-by trailer". But it does not say anything about people who cannot certify. A natural reading may be that if you cannot certify, you do not add the trailer, but it shouldn't hurt to be overly explicit.

This is a good change.

Thanks,
-Stolee

#4 lore raw

PATCH v2 1/1 SubmittingPatches: tighten wording on "sign-off" procedure

In reply to Junio C Hamano

The text says "if you can certify DCO then you add a Signed-off-by trailer". But it does not say anything about people who cannot or do not want to certify. A natural reading may be that if you do not certify, you must not add the trailer, but it shouldn't hurt to be overly explicit.

---
 Documentation/SubmittingPatches | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/SubmittingPatches +1 -1
index d12094bac5..0452db2e67 100644
@@ -307,7 +307,7 @@ wrote the patch or have the right to pass it on under the same license
 as ours, by "signing off" your patch.  Without sign-off, we cannot
 accept your patches.
 
-If you can certify the below D-C-O:
+If (and only if) you certify the below D-C-O:
 
 [[dco]]
 .Developer's Certificate of Origin 1.1
Signature · 1 line
2.30.0-274-g31e3a2ed96