Skip to contentSkip to conversation

doc: fix git grep args order in Quick Reference

PATCH In review Guillaume Jacob via GitGitGadget 2 participants 2 messages Mar 16 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: fix git grep args order in Quick Reference

From: Guillaume Jacob <[email protected]>

The example provided has its arguments in the wrong order. The revision should follow the pattern, and not the other way around.

---
doc: fix git grep args order in Quick Reference

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2069%2Fguillaume-jcb%2Fdoc-fix-args-order-in-quick-ref-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2069/guillaume-jcb/doc-fix-args-order-in-quick-ref-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2069

 Documentation/user-manual.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/user-manual.adoc +1 -1
index 7696987117..64009baf37 100644
@@ -4466,7 +4466,7 @@ $ git show		    # most recent commit
 $ git diff v2.6.15..v2.6.16 # diff between two tagged versions
 $ git diff v2.6.15..HEAD    # diff with current head
 $ git grep "foo()"	    # search working directory for "foo()"
-$ git grep v2.6.15 "foo()"  # search old tree for "foo()"
+$ git grep "foo()" v2.6.15  # search old tree for "foo()"
 $ git show v2.6.15:a.txt    # look at old version of a.txt
 -----------------------------------------------
 

base-commit: dc6ecd5354dca88d51b6d6562777fc8fc10d77e1

Signature · 1 line
gitgitgadget
#1 lore raw
Quoted 4 lines · Guillaume Jacob via GitGitGadget

From: Guillaume Jacob <[email protected]>

The example provided has its arguments in the wrong order. The revision should follow the pattern, and not the other way around.

Well written. The patch title also comforms our convention.

Quoted 3 lines

---

Signed off correctly with the same identity as in-body From: line. The patch contents also is reasonable.

Will queue. Thanks.

Quoted 24 lines

doc: fix git grep args order in Quick Reference

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2069%2Fguillaume-jcb%2Fdoc-fix-args-order-in-quick-ref-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2069/guillaume-jcb/doc-fix-args-order-in-quick-ref-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2069

 Documentation/user-manual.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/user-manual.adoc +1 -1
index 7696987117..64009baf37 100644
@@ -4466,7 +4466,7 @@ $ git show		    # most recent commit
 $ git diff v2.6.15..v2.6.16 # diff between two tagged versions
 $ git diff v2.6.15..HEAD    # diff with current head
 $ git grep "foo()"	    # search working directory for "foo()"
-$ git grep v2.6.15 "foo()"  # search old tree for "foo()"
+$ git grep "foo()" v2.6.15  # search old tree for "foo()"
 $ git show v2.6.15:a.txt    # look at old version of a.txt
 -----------------------------------------------
 

base-commit: dc6ecd5354dca88d51b6d6562777fc8fc10d77e1