git-completion.tcsh: fix redirect with noclobber
PATCH 1/1 git-completion.tcsh: fix redirect with noclobber
tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated.
Adding a ! in the redirect works correctly for both clobber (default) and 'set noclobber' users.
---
contrib/completion/git-completion.tcsh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
contrib/completion/git-completion.tcsh +1 -1
@@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then exit endif -cat << EOF > ${__git_tcsh_completion_script} +cat << EOF >! ${__git_tcsh_completion_script} #!bash # # This script is GENERATED and will be overwritten automatically.
Quoted 11 lines · Ariel Faigon
tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated.
Adding a
!in the redirect works correctly for both clobber (default) and 'set noclobber' users.Helped-by Junio C Hamano <[email protected]>Reviewed-by Christian Couder <[email protected]>Signed-off-by Ariel Faigon <[email protected]>---
Thanks for enduring three iterations for a single-liner. This versio will show nicely in "git log -p" output ;-)
In case anybody is wondering, that "Helped-by: notifications@github" was merely because I said "this change makes sense, care to send it over to us at git@vger?" from github UI on Ariel's commit. I do not deserve helped-by for merely encouraging participation.
Will queue. Thanks again.
Quoted 17 lines
contrib/completion/git-completion.tcsh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)contrib/completion/git-completion.tcsh +1
-1@@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then exit endif -cat << EOF > ${__git_tcsh_completion_script} +cat << EOF >! ${__git_tcsh_completion_script} #!bash # # This script is GENERATED and will be overwritten automatically.