Skip to contentSkip to conversation

qla1280 bus reset typo

PATCH New Jes Sorensen 1 participant 1 message Oct 17, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qla1280 bus reset typo

Hi,

This one falls in the 'must wear a brown paper bag when going out in public' deparment. Please apply as soon as possible. The actual fix is obfuscated inbetween the cleanup of the printk message to hide the embarrassment.

Thanks,
Jes

Fix typo in check of return value of qla1280_bus_reset() which would result in an adapter reset in addition to the bus reset.

---
 drivers/scsi/qla1280.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/scsi/qla1280.c +3 -4
Index: linux-2.6/drivers/scsi/qla1280.c
===================================================================
@@ -931,11 +931,10 @@ qla1280_error_action(struct scsi_cmnd *c
 
 	case BUS_RESET:
 		if (qla1280_verbose)
-			printk(KERN_INFO "qla1280(%ld:%d): Issuing BUS "
-			       "DEVICE RESET\n", ha->host_no, bus);
-		if (qla1280_bus_reset(ha, bus == 0))
+			printk(KERN_INFO "qla1280(%ld:%d): Issued bus "
+			       "reset.\n", ha->host_no, bus);
+		if (qla1280_bus_reset(ha, bus) == 0)
 			result = SUCCESS;
-
 		break;
 
 	case ADAPTER_RESET: