Skip to contentSkip to conversation

scsi: pm80xx: Use module param to set pcs event log severity

PATCH Applied Salomon Dushimirimana 3 participants 7 messages Oct 16, 2024 – Nov 14, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: pm80xx: Use module param to set pcs event log severity

The pm8006 driver sets pcs event log threshold very high which causes most of the FW logs to not be captured. This adds a module parameter to configure pcs event log severity with 3 (medium severity) as the default.

---
 drivers/scsi/pm8001/pm8001_init.c | 4 ++++
 drivers/scsi/pm8001/pm8001_sas.h  | 2 ++
 drivers/scsi/pm8001/pm80xx_hwi.c  | 3 ++-
 3 files changed, 8 insertions(+), 1 deletion(-)
drivers/scsi/pm8001/pm8001_init.c +4 -0
index 1e63cb6cd8e3..355aab0c982a 100644
@@ -68,6 +68,10 @@ static bool pm8001_read_wwn = true;
 module_param_named(read_wwn, pm8001_read_wwn, bool, 0444);
 MODULE_PARM_DESC(zoned, "Get WWN from the controller. Default: true");
 
+uint pcs_event_log_severity = 0x03;
+module_param(pcs_event_log_severity, int, 0644);
+MODULE_PARM_DESC(pcs_event_log_severity, "PCS event log severity level");
+
 static struct scsi_transport_template *pm8001_stt;
 static int pm8001_init_ccb_tag(struct pm8001_hba_info *);
 
drivers/scsi/pm8001/pm8001_sas.h +2 -0
index ced6721380a8..42c7b3f7afbf 100644
@@ -96,6 +96,8 @@ extern struct list_head hba_list;
 extern const struct pm8001_dispatch pm8001_8001_dispatch;
 extern const struct pm8001_dispatch pm8001_80xx_dispatch;
 
+extern uint pcs_event_log_severity;
+
 struct pm8001_hba_info;
 struct pm8001_ccb_info;
 struct pm8001_device;
drivers/scsi/pm8001/pm80xx_hwi.c +2 -1
index 8fe886dc5e47..9b237a764d0b 100644
@@ -763,7 +763,8 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha)
 		pm8001_ha->memoryMap.region[IOP].phys_addr_lo;
 	pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_size		=
 							PM8001_EVENT_LOG_SIZE;
-	pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity	= 0x01;
+	pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity	=
+		pcs_event_log_severity;
 	pm8001_ha->main_cfg_tbl.pm80xx_tbl.fatal_err_interrupt		= 0x01;
 
 	/* Enable higher IQs and OQs, 32 to 63, bit 16 */
Signature · 1 line
2.47.0.rc1.288.g06298d1525-goog
#1 lore raw

Hi,

Quoted 5 lines · Salomon Dushimirimana

The pm8006 driver sets pcs event log threshold very high which causes most of the FW logs to not be captured. This adds a module parameter to configure pcs event log severity with 3 (medium severity) as the default.

upstream does not like more module parameters, can we just change the default to 3, any harm?

Thx!

Quoted 54 lines
---
 drivers/scsi/pm8001/pm8001_init.c | 4 ++++
 drivers/scsi/pm8001/pm8001_sas.h  | 2 ++
 drivers/scsi/pm8001/pm80xx_hwi.c  | 3 ++-
 3 files changed, 8 insertions(+), 1 deletion(-)
drivers/scsi/pm8001/pm8001_init.c +4 -0
index 1e63cb6cd8e3..355aab0c982a 100644
@@ -68,6 +68,10 @@ static bool pm8001_read_wwn = true;
 module_param_named(read_wwn, pm8001_read_wwn, bool, 0444);
 MODULE_PARM_DESC(zoned, "Get WWN from the controller. Default: true");
 
+uint pcs_event_log_severity = 0x03;
+module_param(pcs_event_log_severity, int, 0644);
+MODULE_PARM_DESC(pcs_event_log_severity, "PCS event log severity level");
+
 static struct scsi_transport_template *pm8001_stt;
 static int pm8001_init_ccb_tag(struct pm8001_hba_info *);
 
drivers/scsi/pm8001/pm8001_sas.h +2 -0
index ced6721380a8..42c7b3f7afbf 100644
@@ -96,6 +96,8 @@ extern struct list_head hba_list;
 extern const struct pm8001_dispatch pm8001_8001_dispatch;
 extern const struct pm8001_dispatch pm8001_80xx_dispatch;
 
+extern uint pcs_event_log_severity;
+
 struct pm8001_hba_info;
 struct pm8001_ccb_info;
 struct pm8001_device;
drivers/scsi/pm8001/pm80xx_hwi.c +2 -2
index 8fe886dc5e47..9b237a764d0b 100644
@@ -763,7 +763,8 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha)
                pm8001_ha->memoryMap.region[IOP].phys_addr_lo;
        pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_size           =
                                                        PM8001_EVENT_LOG_SIZE;
-       pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity       = 0x01;
+       pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity       =
+               pcs_event_log_severity;
        pm8001_ha->main_cfg_tbl.pm80xx_tbl.fatal_err_interrupt          = 0x01;
 
        /* Enable higher IQs and OQs, 32 to 63, bit 16 */
--

2.47.0.rc1.288.g06298d1525-goog

#2 lore raw

Hi,

3 works well for Google, but a different value might be better for others. Having a module parameter would allow users to customize the level of logging based on their specific needs. If that is not a concern, I can change the default to just 3.

Thank you!

Salomon Dushimirimana

Quoted 68 lines · Jinpu Wang

Hi,

Quoted 5 lines · Salomon Dushimirimana

The pm8006 driver sets pcs event log threshold very high which causes most of the FW logs to not be captured. This adds a module parameter to configure pcs event log severity with 3 (medium severity) as the default.

upstream does not like more module parameters, can we just change the default to 3, any harm?

Thx!

Quoted 54 lines
---
 drivers/scsi/pm8001/pm8001_init.c | 4 ++++
 drivers/scsi/pm8001/pm8001_sas.h  | 2 ++
 drivers/scsi/pm8001/pm80xx_hwi.c  | 3 ++-
 3 files changed, 8 insertions(+), 1 deletion(-)
drivers/scsi/pm8001/pm8001_init.c +4 -0
index 1e63cb6cd8e3..355aab0c982a 100644
@@ -68,6 +68,10 @@ static bool pm8001_read_wwn = true;
 module_param_named(read_wwn, pm8001_read_wwn, bool, 0444);
 MODULE_PARM_DESC(zoned, "Get WWN from the controller. Default: true");
 
+uint pcs_event_log_severity = 0x03;
+module_param(pcs_event_log_severity, int, 0644);
+MODULE_PARM_DESC(pcs_event_log_severity, "PCS event log severity level");
+
 static struct scsi_transport_template *pm8001_stt;
 static int pm8001_init_ccb_tag(struct pm8001_hba_info *);
 
drivers/scsi/pm8001/pm8001_sas.h +2 -0
index ced6721380a8..42c7b3f7afbf 100644
@@ -96,6 +96,8 @@ extern struct list_head hba_list;
 extern const struct pm8001_dispatch pm8001_8001_dispatch;
 extern const struct pm8001_dispatch pm8001_80xx_dispatch;
 
+extern uint pcs_event_log_severity;
+
 struct pm8001_hba_info;
 struct pm8001_ccb_info;
 struct pm8001_device;
drivers/scsi/pm8001/pm80xx_hwi.c +2 -2
index 8fe886dc5e47..9b237a764d0b 100644
@@ -763,7 +763,8 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha)
                pm8001_ha->memoryMap.region[IOP].phys_addr_lo;
        pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_size           =
                                                        PM8001_EVENT_LOG_SIZE;
-       pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity       = 0x01;
+       pm8001_ha->main_cfg_tbl.pm80xx_tbl.pcs_event_log_severity       =
+               pcs_event_log_severity;
        pm8001_ha->main_cfg_tbl.pm80xx_tbl.fatal_err_interrupt          = 0x01;
 
        /* Enable higher IQs and OQs, 32 to 63, bit 16 */
--

2.47.0.rc1.288.g06298d1525-goog

#3 lore raw

Salomon,

Quoted 4 lines

3 works well for Google, but a different value might be better for others. Having a module parameter would allow users to customize the level of logging based on their specific needs. If that is not a concern, I can change the default to just 3.

How verbose will a value of 3 be during normal operation? I don't object to capturing more information during failure scenarios as long as we're not flooding the logs with noise when things are nominal.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#4 lore raw

Hi,

These are the log levels and their descriptions for the pm80xx controllers - 0 - Disable logging
1 - Critical error
2 - Warning
3 - Notice
4 - Information
5 - Debugging
6 - Reserved

Loglevel 3 helps capture messages of severity level 3 and above. It is not expected to be verbose and helps avoid the log overflow problem.

For debugging, there may be a need to change the loglevel, hence making it configurable.

Thanks,
Salomon Dushimirimana

Salomon Dushimirimana

Quoted 15 lines · Martin K. Petersen

Salomon,

Quoted 4 lines

3 works well for Google, but a different value might be better for others. Having a module parameter would allow users to customize the level of logging based on their specific needs. If that is not a concern, I can change the default to just 3.

How verbose will a value of 3 be during normal operation? I don't object to capturing more information during failure scenarios as long as we're not flooding the logs with noise when things are nominal.

--
Martin K. Petersen Oracle Linux Engineering

#5 lore raw
In reply to Salomon Dushimirimana

Salomon,

Quoted 4 lines

The pm8006 driver sets pcs event log threshold very high which causes most of the FW logs to not be captured. This adds a module parameter to configure pcs event log severity with 3 (medium severity) as the default.

Applied to 6.13/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#6 lore raw
In reply to Salomon Dushimirimana
Quoted 6 lines · Salomon Dushimirimana

The pm8006 driver sets pcs event log threshold very high which causes most of the FW logs to not be captured. This adds a module parameter to configure pcs event log severity with 3 (medium severity) as the default.

Applied to 6.13/scsi-queue, thanks!

[1/1] scsi: pm80xx: Use module param to set pcs event log severity

      https://git.kernel.org/mkp/scsi/c/c8d81a438544
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering