Skip to contentSkip to conversation

qla2xxx: Log PCI address in qla_nvme_unregister_remote_port()

PATCH Applied Daniel Wagner 3 participants 4 messages May 31, 2021 – Jun 8, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qla2xxx: Log PCI address in qla_nvme_unregister_remote_port()

Pass in fcport->vha to ql_log() in order to add the PCI address to the log.

Currently NULL is passed in which gives this confusing log entry:

Quoted 1 line

qla2xxx [0000:00:00.0]-2112: : qla_nvme_unregister_remote_port: unregister remoteport on 0000000009d6a2e9 50000973981648c7

---
 drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_nvme.c +1 -1
index 0cacb667a88b..e119f8b24e33 100644
@@ -671,7 +671,7 @@ void qla_nvme_unregister_remote_port(struct fc_port *fcport)
 	if (!IS_ENABLED(CONFIG_NVME_FC))
 		return;
 
-	ql_log(ql_log_warn, NULL, 0x2112,
+	ql_log(ql_log_warn, fcport->vha, 0x2112,
 	    "%s: unregister remoteport on %p %8phN\n",
 	    __func__, fcport, fcport->port_name);
 
Signature · 1 line
2.29.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Daniel Wagner

Pass in fcport->vha to ql_log() in order to add the PCI address to the log.

Currently NULL is passed in which gives this confusing log entry:

Quoted 1 line

qla2xxx [0000:00:00.0]-2112: : qla_nvme_unregister_remote_port: unregister remoteport on 0000000009d6a2e9 50000973981648c7

---
  drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_nvme.c +0 -0
index 0cacb667a88b..e119f8b24e33 100644

drivers/scsi/qla2xxx/qla_nvme.c void qla_nvme_unregister_remote_port(struct fc_port *fcport) · line 677

Quoted 8 lines
drivers/scsi/qla2xxx/qla_nvme.c +1 -1
@@ -671,7 +671,7 @@ void qla_nvme_unregister_remote_port(struct fc_port *fcport)
  	if (!IS_ENABLED(CONFIG_NVME_FC))
  		return;
 
-	ql_log(ql_log_warn, NULL, 0x2112,
+	ql_log(ql_log_warn, fcport->vha, 0x2112,
  	    "%s: unregister remoteport on %p %8phN\n",
  	    __func__, fcport, fcport->port_name);
 
Signature · 1 line
Himanshu Madhani                                Oracle Linux Engineering
#2 lore raw
In reply to Daniel Wagner

Daniel,

Quoted 2 lines

Pass in fcport->vha to ql_log() in order to add the PCI address to the log.

Applied to 5.14/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#3 lore raw
In reply to Daniel Wagner
Quoted 6 lines · Daniel Wagner

Pass in fcport->vha to ql_log() in order to add the PCI address to the log.

Currently NULL is passed in which gives this confusing log entry:

Quoted 1 line

qla2xxx [0000:00:00.0]-2112: : qla_nvme_unregister_remote_port: unregister remoteport on 0000000009d6a2e9 50000973981648c7

Applied to 5.14/scsi-queue, thanks!

[1/1] qla2xxx: Log PCI address in qla_nvme_unregister_remote_port()

      https://git.kernel.org/mkp/scsi/c/27c707b14659
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering