scsi: qedf: Drop unnecessary NULL checks after container_of
Subsystems (2)
PATCH 1/1 scsi: qedf: Drop unnecessary NULL checks after container_of
The result of container_of() operations is never NULL unless the embedded element is the first element of the structure, which is not the case here. The NULL checks are therefore unnecessary and misleading. Remove them.
The changes in this patch were made automatically using the following Coccinelle script.
@@
type t;
identifier v;
statement s;
@@
<+...
(
t v = container_of(...);
|
v = container_of(...);
)
...
when != v
- if (\( !v \| v == NULL \) ) s
...+>
--- drivers/scsi/qedf/qedf_io.c | 5 ----- drivers/scsi/qedf/qedf_main.c | 4 ---- 2 files changed, 9 deletions(-)
drivers/scsi/qedf/qedf_io.c +0 -5
@@ -23,11 +23,6 @@ static void qedf_cmd_timeout(struct work_struct *work)struct qedf_ctx *qedf;struct qedf_rport *fcport; -if (io_req ==NULL ) { -QEDF_INFO (NULL ,QEDF_LOG_IO ,"io_req is NULL.\n" ); -return ; - } - fcport = io_req->fcport;if (io_req->fcport ==NULL ) {QEDF_INFO (NULL ,QEDF_LOG_IO ,"fcport is NULL.\n" );
drivers/scsi/qedf/qedf_main.c +0 -4
@@ -3971,10 +3971,6 @@ void qedf_stag_change_work(struct work_struct *work)struct qedf_ctx *qedf = container_of(work, struct qedf_ctx, stag_work.work); -if (!qedf) { -QEDF_ERR (NULL ,"qedf is NULL" ); -return ; - }QEDF_ERR (&qedf->dbg_ctx,"Performing software context reset.\n" );qedf_ctx_soft_reset (qedf->lport); }
Signature · 1 line
2.25.1
Martin K. Petersen
AppliedGuenter,
Quoted 4 lines
The result of
container_of()operations is never NULL unless the embedded element is the first element of the structure, which is not the case here. The NULL checks are therefore unnecessary and misleading. Remove them.
Applied to 5.14/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering