Skip to contentSkip to conversation

qla2xxx: Remove duplicate of vha->iocb_work initialization

PATCH Applied Gleb Chesnokov 2 participants 3 messages Nov 15, 2022 – Dec 1, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 qla2xxx: Remove duplicate of vha->iocb_work initialization

Commit 9b3e0f4d4147 ("scsi: qla2xxx: Move work element processing out of DPC thread") introduced the initialization of vha->iocb_work in qla2x00_create_host() function.

This initialization is also called from qla2x00_probe_one() function, just after qla2x00_create_host().

Hence remove this duplicate call since it has already been called before.

---
 drivers/scsi/qla2xxx/qla_os.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/qla2xxx/qla_os.c +0 -1
index 2c85f3cce726..9d82921d94b8 100644
@@ -3284,7 +3284,6 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	    host->max_cmd_len, host->max_channel, host->max_lun,
 	    host->transportt, sht->vendor_id);
 
-	INIT_WORK(&base_vha->iocb_work, qla2x00_iocb_work_fn);
 	INIT_WORK(&ha->heartbeat_work, qla_heartbeat_work_fn);
 
 	/* Set up the irqs */
Signature · 1 line
2.38.1
#1 lore raw

Gleb,

Quoted 3 lines

Commit 9b3e0f4d4147 ("scsi: qla2xxx: Move work element processing out of DPC thread") introduced the initialization of vha->iocb_work in qla2x00_create_host() function.

Applied to 6.2/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Gleb Chesnokov
Quoted 8 lines · Gleb Chesnokov

Commit 9b3e0f4d4147 ("scsi: qla2xxx: Move work element processing out of DPC thread") introduced the initialization of vha->iocb_work in qla2x00_create_host() function.

This initialization is also called from qla2x00_probe_one() function, just after qla2x00_create_host().

[...]

Applied to 6.2/scsi-queue, thanks!

[1/2] qla2xxx: Remove duplicate of vha->iocb_work initialization

      https://git.kernel.org/mkp/scsi/c/3620e174d260
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering