Skip to contentSkip to conversation

elx: efct: fix vport list linkage in lio backend

PATCH Applied James Smart 2 participants 3 messages Jun 19, 2021 – Jun 29, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 elx: efct: fix vport list linkage in lio backend

vport is linked onto the drivers vport list at allocation, but failure path fails to removed from the list.

Change location of linkage until after complete vport completion.

Fixes 692e5d73a811 ("scsi: elx: efct: LIO backend interface routines")
---
 drivers/scsi/elx/efct/efct_lio.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/elx/efct/efct_lio.c +4 -4
index e1bab2b17e4d..6ad5168a86ca 100644
@@ -832,10 +832,6 @@ efct_lio_npiv_make_nport(struct target_fabric_configfs *tf,
 	}
 
 	vport_list->lio_vport = lio_vport;
-	spin_lock_irqsave(&efct->tgt_efct.efct_lio_lock, flags);
-	INIT_LIST_HEAD(&vport_list->list_entry);
-	list_add_tail(&vport_list->list_entry, &efct->tgt_efct.vport_list);
-	spin_unlock_irqrestore(&efct->tgt_efct.efct_lio_lock, flags);
 
 	memset(&vport_id, 0, sizeof(vport_id));
 	vport_id.port_name = npiv_wwpn;
@@ -853,6 +849,10 @@ efct_lio_npiv_make_nport(struct target_fabric_configfs *tf,
 	}
 
 	lio_vport->fc_vport = new_fc_vport;
+	spin_lock_irqsave(&efct->tgt_efct.efct_lio_lock, flags);
+	INIT_LIST_HEAD(&vport_list->list_entry);
+	list_add_tail(&vport_list->list_entry, &efct->tgt_efct.vport_list);
+	spin_unlock_irqrestore(&efct->tgt_efct.efct_lio_lock, flags);
 
 	return &lio_vport->vport_wwn;
 }
Signature · 1 line
2.26.2
#1 lore raw

James,

Quoted 2 lines

vport is linked onto the drivers vport list at allocation, but failure path fails to removed from the list.

Applied to 5.14/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to James Smart
Quoted 4 lines · James Smart

vport is linked onto the drivers vport list at allocation, but failure path fails to removed from the list.

Change location of linkage until after complete vport completion.

Applied to 5.14/scsi-queue, thanks!

[1/1] elx: efct: fix vport list linkage in lio backend

      https://git.kernel.org/mkp/scsi/c/f7c95d7460e3
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering