Skip to contentSkip to conversation

scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed

PATCH Applied Ye Bin 2 participants 3 messages Sep 16, 2020 – Oct 7, 2020

Subsystems (2)
lore
Share & tools
lore

Ye Bin

author
#0 lore raw

PATCH 1/1 scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed

Fixes coccicheck warning:
drivers/scsi/qla4xxx/ql4_init.c:1173:5-11: Unneeded variable: "status". Return "QLA_ERROR" on line 1195

---
 drivers/scsi/qla4xxx/ql4_init.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/qla4xxx/ql4_init.c +1 -2
index 4a7ef971a387..6444f4bb61b3 100644
@@ -1170,7 +1170,6 @@ int qla4xxx_process_ddb_changed(struct scsi_qla_host *ha,
 				uint32_t state, uint32_t conn_err)
 {
 	struct ddb_entry *ddb_entry;
-	int status = QLA_ERROR;
 
 	/* check for out of range index */
 	if (fw_ddb_index >= MAX_DDB_ENTRIES)
@@ -1192,7 +1191,7 @@ int qla4xxx_process_ddb_changed(struct scsi_qla_host *ha,
 	ddb_entry->ddb_change(ha, fw_ddb_index, ddb_entry, state);
 
 exit_ddb_event:
-	return status;
+	return QLA_ERROR;
 }
 
 /**
Signature · 1 line
2.25.4
#1 lore raw

Ye,

Quoted 2 lines

Fixes coccicheck warning:
drivers/scsi/qla4xxx/ql4_init.c:1173:5-11: Unneeded variable: "status". Return "QLA_ERROR" on line 1195

Applied to 5.10/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Ye Bin
Quoted 2 lines · Ye Bin

Fixes coccicheck warning:
drivers/scsi/qla4xxx/ql4_init.c:1173:5-11: Unneeded variable: "status". Return "QLA_ERROR" on line 1195

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed

      https://git.kernel.org/mkp/scsi/c/121432e87093
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering