SCSI: use kobj_to_dev
PATCH 1/1 SCSI: use kobj_to_dev
From: Guosong Su <[email protected]>
Use kobj_to_dev to instead of open-coding it.
Signed-off-by Guosong Su <[email protected]>
--- drivers/scsi/scsi_sysfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/scsi_sysfs.c +4 -4
@@ -856,7 +856,7 @@ show_vpd_##_page(struct file *filp, struct kobject *kobj, \struct bin_attribute *bin_attr, \ char *buf, loff_t off, size_t count) \ { \ - struct device *dev = container_of(kobj, struct device, kobj); \ + struct device *dev = kobj_to_dev(kobj); \struct scsi_device *sdev =to_scsi_device (dev); \struct scsi_vpd *vpd_page; \int ret = -EINVAL ; \
@@ -884,7 +884,7 @@ static ssize_t show_inquiry(struct file *filep, struct kobject *kobj,struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj);struct scsi_device *sdev =to_scsi_device (dev);if (!sdev->inquiry)
@@ -1181,7 +1181,7 @@ static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,static umode_t scsi_sdev_attr_is_visible (struct kobject *kobj,struct attribute *attr,int i) { - struct device *dev = container_of(kobj, struct device, kobj); +struct device *dev =kobj_to_dev (kobj);struct scsi_device *sdev =to_scsi_device (dev);
@@ -1207,7 +1207,7 @@ static umode_t scsi_sdev_attr_is_visible(struct kobject *kobj,static umode_t scsi_sdev_bin_attr_is_visible (struct kobject *kobj,struct bin_attribute *attr,int i) { - struct device *dev = container_of(kobj, struct device, kobj); +struct device *dev =kobj_to_dev (kobj);struct scsi_device *sdev =to_scsi_device (dev);
Signature · 1 line
2.14.1
Quoted 3 lines · On 2020-02-25 02:04, [email protected] wrote:
From: Guosong Su <[email protected]>
Use
kobj_to_devto instead of open-coding it.
Reviewed-by Bart Van Assche <[email protected]>
Martin K. Petersen
AppliedGuosong,
Quoted 1 line
Use
kobj_to_devto instead of open-coding it.
Applied to 5.7/scsi-queue, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering