Skip to contentSkip to conversation

lpfc: Raise config max for lpfc_fcp_mq_threshold variable

PATCH Applied James Smart 3 participants 3 messages Aug 27, 2019 – Aug 29, 2019

Subsystems (2)
SCSI Emulex/Broadcom lpfc FC/FCoE SCSI driver
lore
Share & tools
lore

James Smart

author
#0 lore raw

PATCH 1/1 lpfc: Raise config max for lpfc_fcp_mq_threshold variable

Raise the config max for lpfc_fcp_mq_threshold variable to 256.

Signed-off-by Dick Kennedy <[email protected]>
Signed-off-by James Smart <[email protected]>
CC Hannes Reinecke <[email protected]>

---
Martin, this fix applies 5.3/scsi-fixes patch:
scsi: lpfc: Mitigate high memory pre-allocation by SCSI-MQ

---
 drivers/scsi/lpfc/lpfc_attr.c | 2 +-
 drivers/scsi/lpfc/lpfc_sli4.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_attr.c +1 -1
index 491a999056aa..25aa7a53d255 100644
@@ -5713,7 +5713,7 @@ LPFC_ATTR_RW(nvme_embed_cmd, 1, 0, 2,
  *      0    = Set nr_hw_queues by the number of CPUs or HW queues.
  *      1,128 = Manually specify the maximum nr_hw_queue value to be set,
  *
- * Value range is [0,128]. Default value is 8.
+ * Value range is [0,256]. Default value is 8.
  */
 LPFC_ATTR_R(fcp_mq_threshold, LPFC_FCP_MQ_THRESHOLD_DEF,
 	    LPFC_FCP_MQ_THRESHOLD_MIN, LPFC_FCP_MQ_THRESHOLD_MAX,
drivers/scsi/lpfc/lpfc_sli4.h +1 -1
index 2d1823e449aa..a4be83d1f37e 100644
@@ -46,7 +46,7 @@
 
 /* FCP MQ queue count limiting */
 #define LPFC_FCP_MQ_THRESHOLD_MIN	0
-#define LPFC_FCP_MQ_THRESHOLD_MAX	128
+#define LPFC_FCP_MQ_THRESHOLD_MAX	256
 #define LPFC_FCP_MQ_THRESHOLD_DEF	8
 
 /* Common buffer size to accomidate SCSI and NVME IO buffers */
Signature · 1 line
2.13.7
Reviewed-by on v1 1/1
#1 lore raw
Quoted 33 lines · James Smart

Raise the config max for lpfc_fcp_mq_threshold variable to 256.

Signed-off-by Dick Kennedy <[email protected]>
Signed-off-by James Smart <[email protected]>
CC Hannes Reinecke <[email protected]>

---
Martin, this fix applies 5.3/scsi-fixes patch:
scsi: lpfc: Mitigate high memory pre-allocation by SCSI-MQ

---
  drivers/scsi/lpfc/lpfc_attr.c | 2 +-
  drivers/scsi/lpfc/lpfc_sli4.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_attr.c +1 -1
index 491a999056aa..25aa7a53d255 100644
@@ -5713,7 +5713,7 @@ LPFC_ATTR_RW(nvme_embed_cmd, 1, 0, 2,
   *      0    = Set nr_hw_queues by the number of CPUs or HW queues.
   *      1,128 = Manually specify the maximum nr_hw_queue value to be set,
   *
- * Value range is [0,128]. Default value is 8.
+ * Value range is [0,256]. Default value is 8.
   */
  LPFC_ATTR_R(fcp_mq_threshold, LPFC_FCP_MQ_THRESHOLD_DEF,
  	    LPFC_FCP_MQ_THRESHOLD_MIN, LPFC_FCP_MQ_THRESHOLD_MAX,
drivers/scsi/lpfc/lpfc_sli4.h +0 -0
index 2d1823e449aa..a4be83d1f37e 100644

drivers/scsi/lpfc/lpfc_sli4.h line 52

Quoted 8 lines
drivers/scsi/lpfc/lpfc_sli4.h +1 -1
@@ -46,7 +46,7 @@
 
  /* FCP MQ queue count limiting */
  #define LPFC_FCP_MQ_THRESHOLD_MIN	0
-#define LPFC_FCP_MQ_THRESHOLD_MAX	128
+#define LPFC_FCP_MQ_THRESHOLD_MAX	256
  #define LPFC_FCP_MQ_THRESHOLD_DEF	8
 
  /* Common buffer size to accomidate SCSI and NVME IO buffers */
Reviewed-by Hannes Reinecke <[email protected]>

Cheers,

Hannes

Signature · 5 lines
Dr. Hannes Reinecke            Teamlead Storage & Networking
[email protected]                              +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Applied
#2 lore raw
In reply to James Smart

James,

Quoted 1 line

Raise the config max for lpfc_fcp_mq_threshold variable to 256.

Not a big fan of these magic values.

Applied to 5.3/scsi-fixes.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering