dm mpath: fix passing integrity data
Subsystems (3)
PATCH 1/1 dm mpath: fix passing integrity data
After v4.12 commit e2460f2a4bc7 ("dm: mark targets that pass integrity data"), dm-multipath, e.g. on DIF+DIX SCSI disk paths, does not support block integrity any more. So add it to the whitelist.
This is also a pre-requisite to use block integrity with other dm layer(s) on top of multipath, such as kpartx partitions (dm-linear) or LVM.
--- drivers/md/dm-mpath.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/md/dm-mpath.c +2 -1
@@ -2023,7 +2023,8 @@ static int multipath_busy(struct dm_target *ti)static struct target_type multipath_target = { .name ="multipath" , .version = {1 ,12 ,0 }, - .features =DM_TARGET_SINGLETON |DM_TARGET_IMMUTABLE , + .features =DM_TARGET_SINGLETON |DM_TARGET_IMMUTABLE | +DM_TARGET_PASSES_INTEGRITY , .module =THIS_MODULE , .ctr = multipath_ctr, .dtr = multipath_dtr,
Signature · 1 line
2.13.5
Quoted 21 lines · Steffen Maier
After v4.12 commit
e2460f2a4bc7("dm: mark targets that pass integrity data"), dm-multipath, e.g. on DIF+DIX SCSI disk paths, does not support block integrity any more. So add it to the whitelist.This is also a pre-requisite to use block integrity with other dm layer(s) on top of multipath, such as kpartx partitions (dm-linear) or LVM.
Signed-off-by Steffen Maier <[email protected]>Bisected-by Fedor Loshakov <[email protected]>Fixes e2460f2a4bc7 ("dm: mark targets that pass integrity data")Cc <[email protected]> #4.12+--- drivers/md/dm-mpath.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/md/dm-mpath.c +0
-0
drivers/md/dm-mpath.c static int multipath_busy(struct dm_target *ti) · line 2030
Quoted 9 lines
drivers/md/dm-mpath.c +2
-1@@ -2023,7 +2023,8 @@ static int multipath_busy(struct dm_target *ti)static struct target_type multipath_target = { .name ="multipath" , .version = {1 ,12 ,0 }, - .features =DM_TARGET_SINGLETON |DM_TARGET_IMMUTABLE , + .features =DM_TARGET_SINGLETON |DM_TARGET_IMMUTABLE | +DM_TARGET_PASSES_INTEGRITY , .module =THIS_MODULE , .ctr = multipath_ctr, .dtr = multipath_dtr,
Ho-hum.
Thanks for this.
Cheers,
Hannes
Signature · 10 lines
Dr. Hannes Reinecke Teamlead Storage & Networking [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
Steffen,
Quoted 3 lines
After v4.12 commit
e2460f2a4bc7("dm: mark targets that pass integrity data"), dm-multipath, e.g. on DIF+DIX SCSI disk paths, does not support block integrity any more. So add it to the whitelist.
Ugh.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Quoted 20 lines · Steffen Maier
After v4.12 commit
e2460f2a4bc7("dm: mark targets that pass integrity data"), dm-multipath, e.g. on DIF+DIX SCSI disk paths, does not support block integrity any more. So add it to the whitelist.This is also a pre-requisite to use block integrity with other dm layer(s) on top of multipath, such as kpartx partitions (dm-linear) or LVM.
Signed-off-by Steffen Maier <[email protected]>Bisected-by Fedor Loshakov <[email protected]>Fixes e2460f2a4bc7 ("dm: mark targets that pass integrity data")Cc <[email protected]> #4.12+--- drivers/md/dm-mpath.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/md/dm-mpath.c +0
-0
drivers/md/dm-mpath.c static int multipath_busy(struct dm_target *ti) · line 2030
Quoted 9 lines
drivers/md/dm-mpath.c +2
-1@@ -2023,7 +2023,8 @@ static int multipath_busy(struct dm_target *ti)static struct target_type multipath_target = { .name ="multipath" , .version = {1 ,12 ,0 }, - .features =DM_TARGET_SINGLETON |DM_TARGET_IMMUTABLE , + .features =DM_TARGET_SINGLETON |DM_TARGET_IMMUTABLE | +DM_TARGET_PASSES_INTEGRITY , .module =THIS_MODULE , .ctr = multipath_ctr, .dtr = multipath_dtr,
Thanks, I've queued this for 4.16-rc6, will send to Linus tomorrow.