scsi: Use of_property_read_bool() for boolean properties
PATCH 1/1 scsi: Use of_property_read_bool() for boolean properties
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool().
--- drivers/scsi/qlogicpti.c | 11 +++++------ drivers/scsi/sun_esp.c | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-)
drivers/scsi/qlogicpti.c +5 -6
@@ -513,7 +513,7 @@ static int qlogicpti_load_firmware(struct qlogicpti *qpti) qpti->qpti_id); err =1 ; goto out; - } + }sbus_writew (SBUS_CTRL_RESET , qpti->qregs +SBUS_CTRL );sbus_writew ((DMA_CTRL_CCLEAR |DMA_CTRL_CIRQ ), qpti->qregs +CMD_DMA_CTRL );sbus_writew ((DMA_CTRL_CCLEAR |DMA_CTRL_CIRQ ), qpti->qregs +DATA_DMA_CTRL );
@@ -563,7 +563,7 @@ static int qlogicpti_load_firmware(struct qlogicpti *qpti) qpti->qpti_id); err =1 ; goto out; - } + }/* Load it up.. */ for (i =0 ; i < risc_code_length; i++) {
@@ -1136,7 +1136,7 @@ static struct scsi_cmnd *qlogicpti_intr_handler(struct qlogicpti *qpti)if (!(sbus_readw (qpti->qregs +SBUS_STAT ) &SBUS_STAT_RINT ))return NULL ; - + in_ptr =sbus_readw (qpti->qregs +MBOX5 );sbus_writew (HCCTRL_CRIRQ , qpti->qregs +HCCTRL );if (sbus_readw (qpti->qregs +SBUS_SEMAPHORE ) &SBUS_SEMAPHORE_LCK ) {
@@ -1362,9 +1362,8 @@ static int qpti_sbus_probe(struct platform_device *op) fcode =of_get_property (dp,"isp-fcode" ,NULL );if (fcode && fcode[0 ])printk ("(FCode %s)" , fcode); -if (of_find_property (dp,"differential" ,NULL ) !=NULL ) - qpti->differential =1 ; - + qpti->differential =of_property_read_bool (dp,"differential" ); + printk("\nqlogicpti%d: [%s Wide, using %s interface]\n", qpti->qpti_id, (qpti->ultra ? "Ultra" : "Fast"),
drivers/scsi/sun_esp.c +1 -1
@@ -146,7 +146,7 @@ static void esp_get_differential(struct esp *esp)struct device_node *dp; dp = op->dev.of_node; -if (of_find_property (dp,"differential" ,NULL )) +if (of_property_read_bool (dp,"differential" )) esp->flags |=ESP_FLAG_DIFFERENTIAL ;else esp->flags &= ~ESP_FLAG_DIFFERENTIAL ;
Signature · 1 line
2.39.2
Martin K. Petersen
AppliedRob,
Quoted 4 lines
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to
of_property_read_bool().
Applied to 6.4/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 6 lines · Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to
of_property_read_bool().
Applied to 6.4/scsi-queue, thanks!
[1/1] scsi: Use of_property_read_bool() for boolean properties
https://git.kernel.org/mkp/scsi/c/06f8e0714c9f
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering