Skip to contentSkip to conversation

scsi: ufs: Fix NOP OUT timeout value

PATCH Applied Daejun Park 3 participants 5 messages Sep 2, 2020 – Sep 22, 2020 1 message not in the archive SCSI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20200902025852epcms2p2a2d4ac934f4fc09233d4272c96df9ff1@epcms2p2

#1 lore raw

PATCH 1/1 scsi: ufs: Fix NOP OUT timeout value

In some Samsung UFS devices, there is some booting fail issue with low-power UFS device. The reason of this issue is the UFS device has a little bit longer latency for NOP OUT response. It causes booting fail because NOP OUT command is issued during initialization to check whether the device transport protocol is ready or not. This issue is resolved by releasing NOP_OUT_TIMEOUT value.

NOP_OUT_TIMEOUT: 30ms -> 50ms

---
 drivers/scsi/ufs/ufshcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/ufs/ufshcd.c +2 -2
index 06e2439d523c..5cbd0e9e4ef8 100644
@@ -36,8 +36,8 @@
 
 /* NOP OUT retries waiting for NOP IN response */
 #define NOP_OUT_RETRIES    10
-/* Timeout after 30 msecs if NOP OUT hangs without response */
-#define NOP_OUT_TIMEOUT    30 /* msecs */
+/* Timeout after 50 msecs if NOP OUT hangs without response */
+#define NOP_OUT_TIMEOUT    50 /* msecs */
 
 /* Query request retries */
 #define QUERY_REQ_RETRIES 3
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#2 lore raw
Quoted 9 lines

In some Samsung UFS devices, there is some booting fail issue with low-power UFS device. The reason of this issue is the UFS device has a little bit longer latency for NOP OUT response. It causes booting fail because NOP OUT command is issued during initialization to check whether the device transport protocol is ready or not. This issue is resolved by releasing NOP_OUT_TIMEOUT value.

Quoted 3 lines

NOP_OUT_TIMEOUT: 30ms -> 50ms

#3 lore raw

Hi Avri,

Quoted 11 lines
Quoted 10 lines

In some Samsung UFS devices, there is some booting fail issue with low-power UFS device. The reason of this issue is the UFS device has a little bit longer latency for NOP OUT response. It causes booting fail because NOP OUT command is issued during initialization to check whether the device transport protocol is ready or not. This issue is resolved by releasing NOP_OUT_TIMEOUT value.

NOP_OUT_TIMEOUT: 30ms -> 50ms

Thanks for the review.

Bart,
Could you review this patch, please?

Thanks,
Daejun

#4 lore raw
In reply to Daejun Park

Daejun,

Quoted 6 lines

In some Samsung UFS devices, there is some booting fail issue with low-power UFS device. The reason of this issue is the UFS device has a little bit longer latency for NOP OUT response. It causes booting fail because NOP OUT command is issued during initialization to check whether the device transport protocol is ready or not. This issue is resolved by releasing NOP_OUT_TIMEOUT value.

Applied to 5.10/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#5 lore raw
In reply to Daejun Park
Quoted 8 lines · Daejun Park

In some Samsung UFS devices, there is some booting fail issue with low-power UFS device. The reason of this issue is the UFS device has a little bit longer latency for NOP OUT response. It causes booting fail because NOP OUT command is issued during initialization to check whether the device transport protocol is ready or not. This issue is resolved by releasing NOP_OUT_TIMEOUT value.

[...]

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: ufs: Fix NOP OUT timeout value

      https://git.kernel.org/mkp/scsi/c/782e2efb749f
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering