Skip to contentSkip to conversation

scsi: iscsi: fix sysfs visibility checks for CHAP

PATCH Lee Duncan 2 participants 2 messages Dec 4, 2024 2 messages not in the archive SCSI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Lee Duncan

author
#1 lore raw

I see there's a spelling error in the description, so I'll resubmit.

Quoted 40 lines · Lee Duncan

From: Lee Duncan <[email protected]>

The username and password checks were backwards for the sysfs visibility checks, so correct them. This likely went unnoticed, since the visibility/writability for these attributes (username/password and mututual username/password) are all the same.

Fixes 1d063c17298d ('[SCSI] iscsi class: sysfs group is_visible callout for session attrs')
---
 drivers/scsi/scsi_transport_iscsi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/scsi_transport_iscsi.c +4 -5
index fde7de3b1e55..81c57e0e8d90 100644
@@ -4587,13 +4587,13 @@ static umode_t iscsi_session_attr_is_visible(struct kobject *kobj,
        else if (attr == &dev_attr_sess_chap_out_idx.attr)
                param = ISCSI_PARAM_CHAP_OUT_IDX;
        else if (attr == &dev_attr_sess_password.attr)
-               param = ISCSI_PARAM_USERNAME;
+               param = ISCSI_PARAM_PASSWORD;
        else if (attr == &dev_attr_sess_password_in.attr)
-               param = ISCSI_PARAM_USERNAME_IN;
+               param = ISCSI_PARAM_PASSWORD_IN;
        else if (attr == &dev_attr_sess_username.attr)
-               param = ISCSI_PARAM_PASSWORD;
+               param = ISCSI_PARAM_USERNAME;
        else if (attr == &dev_attr_sess_username_in.attr)
-               param = ISCSI_PARAM_PASSWORD_IN;
+               param = ISCSI_PARAM_USERNAME_IN;
        else if (attr == &dev_attr_sess_fast_abort.attr)
                param = ISCSI_PARAM_FAST_ABORT;
        else if (attr == &dev_attr_sess_abort_tmo.attr)
--

2.43.0

A message that is not in the archive (sent off-list or not yet received): CAPj3X_XGg+vT35aHVmxYONVpcjadAE6eSsa=nuUwP-+KHybiFw@mail.gmail.com

#3 lore raw

Hi Lee!

Quoted 3 lines

Ping?

On Sun, Nov 17, 2024 at 11:46 AM Lee Duncan <[email protected]> wrote:

Mail problems? I don't have this submission from you in my inbox and it's neither in lore, nor in patchwork...

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering