scsi: target: iscsi: remove unused variable xfer_len
Subsystems (3)
PATCH 1/1 scsi: target: iscsi: remove unused variable xfer_len
The variable xfer_len is being initialized and incremented but it is never actually referenced in any other way. The variable is redundant and can be removed.
Cleans up clang scan build warning:drivers/target/iscsi/iscsi_target_erl1.c:586:45: warning: variable 'xfer_len' set but not used [-Wunused-but-set-variable]
Signed-off-by Colin Ian King <[email protected]>
--- drivers/target/iscsi/iscsi_target_erl1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/target/iscsi/iscsi_target_erl1.c +1 -2
@@ -583,7 +583,7 @@ int iscsit_dataout_datapduinorder_no_fbit( struct iscsi_pdu *pdu) {int i, send_recovery_r2t =0 , recovery =0 ; -u32 length =0 , offset =0 , pdu_count =0 , xfer_len =0 ; +u32 length =0 , offset =0 , pdu_count =0 ;struct iscsit_conn *conn = cmd->conn;struct iscsi_pdu *first_pdu =NULL ;
@@ -596,7 +596,6 @@ int iscsit_dataout_datapduinorder_no_fbit(if (cmd->pdu_list[i].seq_no == pdu->seq_no) {if (!first_pdu) first_pdu = &cmd->pdu_list[i]; - xfer_len += cmd->pdu_list[i].length; pdu_count++; }else if (pdu_count)break ;
Signature · 1 line
2.39.2
Martin K. Petersen
AppliedColin,
Quoted 3 lines
The variable
xfer_lenis being initialized and incremented but it is never actually referenced in any other way. The variable is redundant and can be removed.
Applied to 6.9/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering