scsi: hisi_sas: Remove unnecessary print function dev_err()
Subsystems (2)
PATCH 1/1 scsi: hisi_sas: Remove unnecessary print function dev_err()
The print function dev_err() is redundant because platform_get_irq() already prints an error.
Eliminate the follow coccicheck warnings:
./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1661:3-10: line 1661 is redundant because platform_get_irq() already prints an error ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1642:4-11: line 1642 is redundant because platform_get_irq() already prints an error ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1679:3-10: line 1679 is redundant because platform_get_irq() already prints an error
--- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-)
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c +3 -12
@@ -1638,11 +1638,8 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba) idx = i *HISI_SAS_PHY_INT_NR ;for (j =0 ; j <HISI_SAS_PHY_INT_NR ; j++, idx++) { irq =platform_get_irq (pdev, idx); -if (irq <0 ) { -dev_err (dev,"irq init: fail map phy interrupt %d\n" , - idx); +if (irq <0 )return irq; - } rc =devm_request_irq (dev, irq, phy_interrupts[j],0 ,DRV_NAME " phy" , phy);
@@ -1657,11 +1654,8 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba) idx = hisi_hba->n_phy *HISI_SAS_PHY_INT_NR ;for (i =0 ; i < hisi_hba->queue_count; i++, idx++) { irq =platform_get_irq (pdev, idx); -if (irq <0 ) { -dev_err (dev,"irq init: could not map cq interrupt %d\n" , - idx); +if (irq <0 )return irq; - } rc =devm_request_irq (dev, irq, cq_interrupt_v1_hw,0 ,DRV_NAME " cq" , &hisi_hba->cq[i]);
@@ -1675,11 +1669,8 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba) idx = (hisi_hba->n_phy *HISI_SAS_PHY_INT_NR ) + hisi_hba->queue_count;for (i =0 ; i <HISI_SAS_FATAL_INT_NR ; i++, idx++) { irq =platform_get_irq (pdev, idx); -if (irq <0 ) { -dev_err (dev,"irq init: could not map fatal interrupt %d\n" , - idx); +if (irq <0 )return irq; - } rc =devm_request_irq (dev, irq, fatal_interrupts[i],0 ,DRV_NAME " fatal" , hisi_hba);
Signature · 1 line
2.20.1.7.g153144c
Quoted 11 lines · Yang Li
The print function
dev_err()is redundant becauseplatform_get_irq()already prints an error.Eliminate the follow coccicheck warnings:
./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1661:3-10: line 1661 is redundant becauseplatform_get_irq()already prints an error ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1642:4-11: line 1642 is redundant becauseplatform_get_irq()already prints an error ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1679:3-10: line 1679 is redundant becauseplatform_get_irq()already prints an error
Quoted 2 lines
Reported-by Abaci Robot<[email protected]>Signed-off-by Yang Li<[email protected]>
Martin K. Petersen
AppliedYang,
Quoted 2 lines
The print function
dev_err()is redundant becauseplatform_get_irq()already prints an error.
Applied to 5.18/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 11 lines · Yang Li
The print function
dev_err()is redundant becauseplatform_get_irq()already prints an error.Eliminate the follow coccicheck warnings:
./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1661:3-10: line 1661 is redundant becauseplatform_get_irq()already prints an error ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1642:4-11: line 1642 is redundant becauseplatform_get_irq()already prints an error ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1679:3-10: line 1679 is redundant becauseplatform_get_irq()already prints an error
Quoted 1 line
[...]
Applied to 5.18/scsi-queue, thanks!
[1/1] scsi: hisi_sas: Remove unnecessary print function dev_err()
https://git.kernel.org/mkp/scsi/c/07dd40b3078f
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering