Skip to contentSkip to conversation

qla2xxx: convert nvme Transport error to internal error

PATCH New James Smart 4 participants 5 messages Sep 14, 2017 – Sep 16, 2017

Subsystems (3)
SCSI NVMe QLogic QLA2XXX FC-SCSI driver
lore
Share & tools
lore

James Smart

author
#0 lore raw

PATCH 1/1 qla2xxx: convert nvme Transport error to internal error

Patch removing transport-specific errors crosssed with a qla2xxx update that referenced the status value being removed.

Swap status to an internal error.

Signed-off-by James Smart <james.smart at broadcom.com>
---
 drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_nvme.c +1 -1
index 1f59e7a74c7b..6b33a1f24f56 100644
@@ -180,7 +180,7 @@ static void qla_nvme_sp_done(void *ptr, int res)
 		goto rel;
 
 	if (unlikely(res == QLA_FUNCTION_FAILED))
-		fd->status = NVME_SC_FC_TRANSPORT_ERROR;
+		fd->status = NVME_SC_INTERNAL;
 	else
 		fd->status = 0;
Signature · 1 line
2.13.1
#1 lore raw

PATCH 1/1 qla2xxx: convert nvme Transport error to internal error

Quoted 29 lines · James Smart

Patch removing transport-specific errors crosssed with a qla2xxx update that referenced the status value being removed.

Swap status to an internal error.

Signed-off-by James Smart <james.smart at broadcom.com>

---
drivers/scsi/qla2xxx/qla_nvme.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_nvme.c +1 -1
index 1f59e7a74c7b..6b33a1f24f56 100644
@@ -180,7 +180,7 @@ static void qla_nvme_sp_done(void *ptr, int res)
 		goto rel;
 
 	if (unlikely(res == QLA_FUNCTION_FAILED))
-		fd->status = NVME_SC_FC_TRANSPORT_ERROR;
+		fd->status = NVME_SC_INTERNAL;
 	else
 		fd->status = 0;
Signature · 1 line
2.13.1

Looks good.

Acked-by Himanshu Madhani <himanshu.madhani at cavium.com>

Thanks,
- Himanshu

Applied
#2 lore raw

PATCH 1/1 qla2xxx: convert nvme Transport error to internal error

Himanshu,

Quoted 4 lines
Quoted 4 lines

Patch removing transport-specific errors crosssed with a qla2xxx update that referenced the status value being removed.

Swap status to an internal error.

Applied to 4.14/scsi-fixes.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
maintainer
#3 lore raw

PATCH 1/1 qla2xxx: convert nvme Transport error to internal error

Quoted 9 lines · Martin K. Petersen

Himanshu,

Quoted 4 lines
Quoted 4 lines

Patch removing transport-specific errors crosssed with a qla2xxx update that referenced the status value being removed.

Swap status to an internal error.

Applied to 4.14/scsi-fixes.

I've already picked this up with the reset of James' series to get rid of these errors in lpfc and the nvme code. I can still rebase the nvme tree, but it will require the scsi tree to get in first which is a little annoying.

#4 lore raw

PATCH 1/1 qla2xxx: convert nvme Transport error to internal error

Christoph,

Quoted 4 lines

I've already picked this up with the reset of James' series to get rid of these errors in lpfc and the nvme code. I can still rebase the nvme tree, but it will require the scsi tree to get in first which is a little annoying.

That's fine. I'll just drop it.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering