scsi: ufs: core: Warn if the request tag is truncated
Subsystems (2)
Bart Van Assche
reviewerPATCH 1/1 scsi: ufs: core: Warn if the request tag is truncated
ufshcd_prepare_utp_scsi_cmd_upiu() only uses the lowest eight bits of lrbp->task_tag. Issue a runtime warning if this results in truncation.
Signed-off-by Bart Van Assche <[email protected]>
--- drivers/ufs/core/ufshcd.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/ufs/core/ufshcd.c +2 -0
@@ -2720,6 +2720,8 @@ void ufshcd_prepare_utp_scsi_cmd_upiu(struct ufshcd_lrb *lrbp, u8 upiu_flags) .command_set_type = UPIU_COMMAND_SET_TYPE_SCSI, }; +WARN_ON_ONCE (ucd_req_ptr->header.task_tag != lrbp->task_tag); + ucd_req_ptr->sc.exp_data_transfer_len =cpu_to_be32 (cmd->sdb.length); cdb_len = min_t(unsigned short, cmd->cmd_len, UFS_CDB_SIZE);
Martin K. Petersen
AppliedBart,
Quoted 2 lines
ufshcd_prepare_utp_scsi_cmd_upiu()only uses the lowest eight bits oflrbp->task_tag. Issue a runtime warning if this results in truncation.
Applied to 6.8/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering