Skip to contentSkip to conversation

elx: libefc_sli: fix anding with zero bit value

PATCH Applied James Smart 2 participants 3 messages Jun 19, 2021 – Jun 29, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 elx: libefc_sli: fix anding with zero bit value

flags value is being set to constant and'd 0 which always results in 0

Remove the assignment line.

Fixes 1628f5b4976f ("scsi: elx: libefc_sli: Populate and post different WQEs")
---
 drivers/scsi/elx/libefc_sli/sli4.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/elx/libefc_sli/sli4.c +0 -2
index fc24a50c5d6b..6c6c04e1b74d 100644
@@ -2381,8 +2381,6 @@ sli_xmit_els_rsp64_wqe(struct sli4 *sli, void *buf, struct efc_dma *rsp,
 
 	els->ox_id = cpu_to_le16(params->ox_id);
 
-	els->flags2 |= SLI4_ELS_IOD & SLI4_ELS_REQUEST64_DIR_WRITE;
-
 	els->flags2 |= SLI4_ELS_QOSD;
 
 	els->cmd_type_wqec = SLI4_ELS_REQUEST64_CMD_GEN;
Signature · 1 line
2.26.2
#1 lore raw

James,

Quoted 1 line

flags value is being set to constant and'd 0 which always results in 0

Applied to 5.14/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering