Skip to contentSkip to conversation

qla4xxx: remove unused count variable

PATCH Applied Tom Rix 2 participants 3 messages Mar 31, 2023 – Apr 12, 2023

Subsystems (2)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 qla4xxx: remove unused count variable

clang with W=1 reports drivers/scsi/qla4xxx/ql4_isr.c:475:11: error: variable
'count' set but not used [-Werror,-Wunused-but-set-variable]

        uint32_t count = 0;
                 ^

This variable is not used so remove it.

---
 drivers/scsi/qla4xxx/ql4_isr.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/qla4xxx/ql4_isr.c +0 -2
index 6f0e77dc2a34..cf52258ecdde 100644
@@ -472,14 +472,12 @@ static void qla4xxx_mbox_status_entry(struct scsi_qla_host *ha,
  **/
 void qla4xxx_process_response_queue(struct scsi_qla_host *ha)
 {
-	uint32_t count = 0;
 	struct srb *srb = NULL;
 	struct status_entry *sts_entry;
 
 	/* Process all responses from response queue */
 	while ((ha->response_ptr->signature != RESPONSE_PROCESSED)) {
 		sts_entry = (struct status_entry *) ha->response_ptr;
-		count++;
 
 		/* Advance pointers for next entry */
 		if (ha->response_out == (RESPONSE_QUEUE_DEPTH - 1)) {
Signature · 1 line
2.27.0
#1 lore raw

Tom,

Quoted 6 lines

clang with W=1 reports drivers/scsi/qla4xxx/ql4_isr.c:475:11: error: variable
'count' set but not used [-Werror,-Wunused-but-set-variable]

        uint32_t count = 0;
                 ^

This variable is not used so remove it.

Applied to 6.4/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Tom Rix
Quoted 8 lines · Tom Rix

clang with W=1 reports drivers/scsi/qla4xxx/ql4_isr.c:475:11: error: variable
'count' set but not used [-Werror,-Wunused-but-set-variable]

        uint32_t count = 0;
                 ^

This variable is not used so remove it.

[...]

Applied to 6.4/scsi-queue, thanks!

[1/1] qla4xxx: remove unused count variable

      https://git.kernel.org/mkp/scsi/c/3d2efb5470f5
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering