Skip to contentSkip to conversation

scsi: ufs: Make the TC G210 driver dependent on CONFIG_OF

PATCH Applied Bart Van Assche 3 participants 3 messages Feb 9, 2023 – Feb 21, 2023 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: Make the TC G210 driver dependent on CONFIG_OF

The TC G210 driver only supports devices declared in the device tree. Hence make this driver dependent on CONFIG_OF. This patch fixes the following compiler error:

drivers/ufs/host/tc-dwc-g210-pltfrm.c:36:34: error: ‘tc_dwc_g210_pltfm_match’ defined but not used [-Werror=unused-const-variable=]

   36 | static const struct of_device_id tc_dwc_g210_pltfm_match[] = {
      |
---
 drivers/ufs/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ufs/host/Kconfig +1 -1
index 139064e70a34..1cb28f9930dc 100644
@@ -48,7 +48,7 @@ config SCSI_UFS_CDNS_PLATFORM
 
 config SCSI_UFS_DWC_TC_PLATFORM
 	tristate "DesignWare platform support using a G210 Test Chip"
-	depends on SCSI_UFSHCD_PLATFORM
+	depends on OF && SCSI_UFSHCD_PLATFORM
 	help
 	  Synopsys Test Chip is a PHY for prototyping purposes.
 
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Bart Van Assche

The TC G210 driver only supports devices declared in the device tree. Hence make this driver dependent on CONFIG_OF. This patch fixes the following compiler error:

drivers/ufs/host/tc-dwc-g210-pltfrm.c:36:34: error: ‘tc_dwc_g210_pltfm_match’ defined but not used [-Werror=unused-const-variable=]

    36 | static const struct of_device_id tc_dwc_g210_pltfm_match[] = {
       |
#2 lore raw
In reply to Bart Van Assche

Bart,

Quoted 3 lines

The TC G210 driver only supports devices declared in the device tree. Hence make this driver dependent on CONFIG_OF. This patch fixes the following compiler error:

Applied to 6.3/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering