scsi: qla2xxx: check correct variable in qla24xx_async_gffid()
Subsystems (3)
PATCH 1/1 scsi: qla2xxx: check correct variable in qla24xx_async_gffid()
There is a copy and paste bug here. It should check ".rsp" instead of ".req".
--- drivers/scsi/qla2xxx/qla_gs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_gs.c +1 -1
@@ -3389,7 +3389,7 @@ int qla24xx_async_gffid(scsi_qla_host_t *vha, fc_port_t *fcport, bool wait) sp->u.iocb_cmd.u.ctarg.rsp_allocated_size, &sp->u.iocb_cmd.u.ctarg.rsp_dma, GFP_KERNEL); -if (!sp->u.iocb_cmd.u.ctarg.req) { +if (!sp->u.iocb_cmd.u.ctarg.rsp) {ql_log (ql_log_warn, vha,0xd041 ,"%s: Failed to allocate ct_sns request.\n" , __func__);
Signature · 1 line
2.35.1
Dan,
drivers/scsi/qla2xxx/qla_gs.c int qla24xx_async_gffid(scsi_qla_host_t *vha, fc_port_t *fcport, bool wait) · line 3395
Quoted 8 lines
There is a copy and paste bug here. It should check ".rsp" instead of ".req".
drivers/scsi/qla2xxx/qla_gs.c +1
-1-if (!sp->u.iocb_cmd.u.ctarg.req) { +if (!sp->u.iocb_cmd.u.ctarg.rsp) {ql_log (ql_log_warn, vha,0xd041 ,"%s: Failed to allocate ct_sns request.\n" , __func__);
I wonder if the log message should be adjusted to say "ct_sns response" or something to that effect?
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
PATCH v2 1/1 scsi: qla2xxx: scsi: qla2xxx: check correct variable in qla24xx_async_gffid()
There is a copy and paste bug here. It should check ".rsp" instead of ".req". The error message is copy and pasted as well so update that too.
---
v2: Update the error message as well
drivers/scsi/qla2xxx/qla_gs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_gs.c +2 -2
@@ -3389,9 +3389,9 @@ int qla24xx_async_gffid(scsi_qla_host_t *vha, fc_port_t *fcport, bool wait) sp->u.iocb_cmd.u.ctarg.rsp_allocated_size, &sp->u.iocb_cmd.u.ctarg.rsp_dma, GFP_KERNEL); -if (!sp->u.iocb_cmd.u.ctarg.req) { +if (!sp->u.iocb_cmd.u.ctarg.rsp) {ql_log (ql_log_warn, vha,0xd041 , -"%s: Failed to allocate ct_sns request.\n" , +"%s: Failed to allocate ct_sns response.\n" , __func__); goto done_free_sp; }
Signature · 1 line
2.35.1
Martin K. Petersen
AppliedRe: [PATCH v2] scsi: qla2xxx: scsi: qla2xxx: check correct variable in qla24xx_async_gffid()
Dan,
Quoted 3 lines
There is a copy and paste bug here. It should check ".rsp" instead of ".req". The error message is copy and pasted as well so update that too.
Applied to 5.20/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedRe: [PATCH v2] scsi: qla2xxx: scsi: qla2xxx: check correct variable in qla24xx_async_gffid()
In reply to Dan CarpenterQuoted 4 lines · Dan Carpenter
There is a copy and paste bug here. It should check ".rsp" instead of ".req". The error message is copy and pasted as well so update that too.
Applied to 5.20/scsi-queue, thanks!
[1/1] scsi: qla2xxx: scsi: qla2xxx: check correct variable in qla24xx_async_gffid()
https://git.kernel.org/mkp/scsi/c/7c33e477bd88
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering