Skip to contentSkip to conversation

scsi: storvsc: Correctly set number of hardware queues for IDE disk

PATCH Applied [email protected] 2 participants 2 messages Jan 14, 2020 – Jan 16, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 scsi: storvsc: Correctly set number of hardware queues for IDE disk

From: Long Li <[email protected]>

Commit 0ed881027690 ("scsi: storvsc: setup 1:1 mapping between hardware queue and CPU queue") introduced a regression for disks attached to IDE. For these disks the host VSP only offers one VMBUS channel. Setting multiple queues can overload the VMBUS channel and result in performance drop for high queue depth workload on system with large number of CPUs.

Fix it by leaving the number of hardware queues to 1 (default value) for IDE disks.

Fixes 0ed881027690 ("scsi: storvsc: setup 1:1 mapping between hardware queue and CPU queue")

---

Changes:
v2: Use pre-computed bool variable dev_is_ide

 drivers/scsi/storvsc_drv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/scsi/storvsc_drv.c +3 -1
index f8faf8b3d965..fb41636519ee 100644
@@ -1842,9 +1842,11 @@ static int storvsc_probe(struct hv_device *device,
 	 */
 	host->sg_tablesize = (stor_device->max_transfer_bytes >> PAGE_SHIFT);
 	/*
+	 * For non-IDE disks, the host supports multiple channels.
 	 * Set the number of HW queues we are supporting.
 	 */
-	host->nr_hw_queues = num_present_cpus();
+	if (!dev_is_ide)
+		host->nr_hw_queues = num_present_cpus();
 
 	/*
 	 * Set the error handler work queue.
Signature · 1 line
2.20.1
#1 lore raw

Long,

Quoted 6 lines

Commit 0ed881027690 ("scsi: storvsc: setup 1:1 mapping between hardware queue and CPU queue") introduced a regression for disks attached to IDE. For these disks the host VSP only offers one VMBUS channel. Setting multiple queues can overload the VMBUS channel and result in performance drop for high queue depth workload on system with large number of CPUs.

Applied to 5.5/scsi-fixes, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering