Skip to contentSkip to conversation

scsi:iscsi: Remove unused list 'connlist_err'

PATCH Applied [email protected] 3 participants 3 messages May 3, 2024 – May 7, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi:iscsi: Remove unused list 'connlist_err'

From: "Dr. David Alan Gilbert" <[email protected]>

I think the last use of this list was removed by
commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure
handling").

Build tested only.

---
 drivers/scsi/scsi_transport_iscsi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/scsi_transport_iscsi.c +0 -1
index af3ac6346796b..123b861d2a9fb 100644
@@ -1603,7 +1603,6 @@ static DEFINE_MUTEX(rx_queue_mutex);
 static LIST_HEAD(sesslist);
 static DEFINE_SPINLOCK(sesslock);
 static LIST_HEAD(connlist);
-static LIST_HEAD(connlist_err);
 static DEFINE_SPINLOCK(connlock);
 
 static uint32_t iscsi_conn_get_sid(struct iscsi_cls_conn *conn)
Signature · 1 line
2.44.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · On 5/3/24 6:23 PM, [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

I think the last use of this list was removed by
commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure
handling").

Build tested only.

---
 drivers/scsi/scsi_transport_iscsi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/scsi_transport_iscsi.c +0 -0
index af3ac6346796b..123b861d2a9fb 100644

drivers/scsi/scsi_transport_iscsi.c static DEFINE_MUTEX(rx_queue_mutex); · line 1608

Quoted 7 lines
drivers/scsi/scsi_transport_iscsi.c +0 -1
@@ -1603,7 +1603,6 @@ static DEFINE_MUTEX(rx_queue_mutex);
 static LIST_HEAD(sesslist);
 static DEFINE_SPINLOCK(sesslock);
 static LIST_HEAD(connlist);
-static LIST_HEAD(connlist_err);
 static DEFINE_SPINLOCK(connlock);
 
 static uint32_t iscsi_conn_get_sid(struct iscsi_cls_conn *conn)
#2 lore raw
In reply to [email protected]
Quoted 6 lines

I think the last use of this list was removed by
commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure
handling").

Build tested only.

Applied to 6.10/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering