Skip to contentSkip to conversation

sbp-target: add the missed kfree() in an error path

PATCH In review Chuhong Yuan 4 participants 4 messages May 28, 2020 – Jun 3, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sbp-target: add the missed kfree() in an error path

sbp_fetch_command() forgets to call kfree() in an error path. Add the missed call to fix it.

Fixes a511ce339780 ("sbp-target: Initial merge of firewire/ieee-1394 target mode support")
---
 drivers/target/sbp/sbp_target.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/target/sbp/sbp_target.c +3 -1
index e4a9b9fe3dfb..504a755ea344 100644
@@ -1128,8 +1128,10 @@ static int sbp_fetch_command(struct sbp_target_request *req)
 				req->orb_pointer + sizeof(req->orb),
 				req->cmd_buf + sizeof(req->orb.command_block),
 				copy_len);
-		if (ret != RCODE_COMPLETE)
+		if (ret != RCODE_COMPLETE) {
+			kfree(req->cmd_buf);
 			return -EIO;
+		}
 	}
 
 	return 0;
Signature · 1 line
2.26.2
#1 lore raw
Quoted 2 lines · Chuhong Yuan

sbp_fetch_command() forgets to call kfree() in an error path. Add the missed call to fix it.

Hi Chris,

The changelog of the code under drivers/target/sbp makes we wonder whether this driver has ever had any other users than its original author. Do you agree with this? If so, do you want to keep this driver in the kernel tree?

Thanks,

Bart.

maintainer
#2 lore raw
Quoted 10 lines · Bart Van Assche
Quoted 2 lines · Chuhong Yuan

sbp_fetch_command() forgets to call kfree() in an error path. Add the missed call to fix it.

Hi Chris,

The changelog of the code under drivers/target/sbp makes we wonder whether this driver has ever had any other users than its original author. Do you agree with this? If so, do you want to keep this driver in the kernel tree?

Hi Bart,

I think you might be right. I also don't have much time to maintain it these days and the hardware I had is long dead. It probably should be removed for everyone's sanity.

Best regards,
Chris

Signature · 2 lines
Chris Boot
[email protected]
#3 lore raw

Chris,

Quoted 2 lines

I think you might be right. I also don't have much time to maintain it these days and the hardware I had is long dead.

In that case I'd appreciate a patch to remove it.

Thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering