Skip to contentSkip to conversation

scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h

PATCH Applied Bart Van Assche 3 participants 4 messages Sep 17, 2021 – Sep 29, 2021 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h

There are no dependencies in <scsi/scsi_cmnd.h> on the <scsi/scsi_host.h> header file. Hence remove the scsi_host.h include directive from scsi_cmnd.h. This include directive was introduced in February 2021 by commit af1830956dc3 ("scsi: core: Add mq_poll support to SCSI layer").

---
 include/scsi/scsi_cmnd.h | 1 -
 1 file changed, 1 deletion(-)
include/scsi/scsi_cmnd.h +0 -1
index eaf04c9a1dfc..a2315aac93c7 100644
@@ -10,7 +10,6 @@
 #include <linux/timer.h>
 #include <linux/scatterlist.h>
 #include <scsi/scsi_device.h>
-#include <scsi/scsi_host.h>
 #include <scsi/scsi_request.h>
 
 struct Scsi_Host;
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Bart Van Assche

There are no dependencies in <scsi/scsi_cmnd.h> on the <scsi/scsi_host.h> header file. Hence remove the scsi_host.h include directive from scsi_cmnd.h. This include directive was introduced in February 2021 by commit af1830956dc3 ("scsi: core: Add mq_poll support to SCSI layer").

---
include/scsi/scsi_cmnd.h | 1 -

1 file changed, 1 deletion(-)
include/scsi/scsi_cmnd.h +0 -0
index eaf04c9a1dfc..a2315aac93c7 100644

include/scsi/scsi_cmnd.h line 15

Quoted 7 lines
include/scsi/scsi_cmnd.h +0 -1
@@ -10,7 +10,6 @@
 #include <linux/timer.h>
 #include <linux/scatterlist.h>
 #include <scsi/scsi_device.h>
-#include <scsi/scsi_host.h>
 #include <scsi/scsi_request.h>
 
 struct Scsi_Host;

--
Himanshu Madhani Oracle Linux Engineering

#2 lore raw
In reply to Bart Van Assche

Bart,

Quoted 4 lines

There are no dependencies in <scsi/scsi_cmnd.h> on the <scsi/scsi_host.h> header file. Hence remove the scsi_host.h include directive from scsi_cmnd.h. This include directive was introduced in February 2021 by commit af1830956dc3 ("scsi: core: Add mq_poll support to SCSI layer").

Applied to 5.16/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#3 lore raw
In reply to Bart Van Assche
Quoted 6 lines · Bart Van Assche

There are no dependencies in <scsi/scsi_cmnd.h> on the <scsi/scsi_host.h> header file. Hence remove the scsi_host.h include directive from scsi_cmnd.h. This include directive was introduced in February 2021 by commit af1830956dc3 ("scsi: core: Add mq_poll support to SCSI layer").

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: core: Remove include <scsi/scsi_host.h> from scsi_cmnd.h

      https://git.kernel.org/mkp/scsi/c/a7c052066986
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering