scsi: target: Remove unused argument of some functions
Subsystems (2)
PATCH 1/1 scsi: target: Remove unused argument of some functions
The se_cmd is unused in these functions, just remove it.
Signed-off-by Li Feng <[email protected]>
--- drivers/target/target_core_xcopy.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/target/target_core_xcopy.c +6 -8
@@ -295,8 +295,7 @@ static int target_xcopy_parse_target_descriptors(struct se_cmd *se_cmd,return -EINVAL ; } -static int target_xcopy_parse_segdesc_02 (struct se_cmd *se_cmd,struct xcopy_op *xop, -unsigned char *p) +static int target_xcopy_parse_segdesc_02 (struct xcopy_op *xop,unsigned char *p) {unsigned char *desc = p;int dc = (desc[1 ] &0x02 );
@@ -332,9 +331,9 @@ static int target_xcopy_parse_segdesc_02(struct se_cmd *se_cmd, struct xcopy_opreturn 0 ; } -static int target_xcopy_parse_segment_descriptors (struct se_cmd *se_cmd, -struct xcopy_op *xop,unsigned char *p, -unsigned int sdll,sense_reason_t *sense_ret) +static int target_xcopy_parse_segment_descriptors (struct xcopy_op *xop, +unsigned char *p,unsigned int sdll, +sense_reason_t *sense_ret) {unsigned char *desc = p;unsigned int start =0 ;
@@ -362,7 +361,7 @@ static int target_xcopy_parse_segment_descriptors(struct se_cmd *se_cmd,*/ switch (desc[0 ]) {case 0x02 : - rc =target_xcopy_parse_segdesc_02 (se_cmd, xop, desc); + rc =target_xcopy_parse_segdesc_02 (xop, desc);if (rc <0 ) goto out;
@@ -840,8 +839,7 @@ static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)*/ seg_desc = &p[16 ] + tdll; - rc =target_xcopy_parse_segment_descriptors (se_cmd, xop, seg_desc, - sdll, &ret); + rc =target_xcopy_parse_segment_descriptors (xop, seg_desc, sdll, &ret);if (rc <=0 ) goto out;
Signature · 1 line
2.31.1
Quoted 59 lines · Li Feng
The
se_cmdis unused in these functions, just remove it.Signed-off-by Li Feng <[email protected]>---
drivers/target/target_core_xcopy.c| 14 ++++++--------1 file changed, 6 insertions(+), 8 deletions(-)drivers/target/target_core_xcopy.c +6
-8@@ -295,8 +295,7 @@ static int target_xcopy_parse_target_descriptors(struct se_cmd *se_cmd,return -EINVAL ; } -static int target_xcopy_parse_segdesc_02 (struct se_cmd *se_cmd,struct xcopy_op *xop, -unsigned char *p) +static int target_xcopy_parse_segdesc_02 (struct xcopy_op *xop,unsigned char *p) {unsigned char *desc = p;int dc = (desc[1 ] &0x02 );@@ -332,9 +331,9 @@ static int target_xcopy_parse_segdesc_02(struct se_cmd *se_cmd, struct xcopy_opreturn 0 ; } -static int target_xcopy_parse_segment_descriptors (struct se_cmd *se_cmd, -struct xcopy_op *xop,unsigned char *p, -unsigned int sdll,sense_reason_t *sense_ret) +static int target_xcopy_parse_segment_descriptors (struct xcopy_op *xop, +unsigned char *p,unsigned int sdll, +sense_reason_t *sense_ret) {unsigned char *desc = p;unsigned int start =0 ;@@ -362,7 +361,7 @@ static int target_xcopy_parse_segment_descriptors(struct se_cmd *se_cmd,*/ switch (desc[0 ]) {case 0x02 : - rc =target_xcopy_parse_segdesc_02 (se_cmd, xop, desc); + rc =target_xcopy_parse_segdesc_02 (xop, desc);if (rc <0 ) goto out;@@ -840,8 +839,7 @@ static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)*/ seg_desc = &p[16 ] + tdll; - rc =target_xcopy_parse_segment_descriptors (se_cmd, xop, seg_desc, - sdll, &ret); + rc =target_xcopy_parse_segment_descriptors (xop, seg_desc, sdll, &ret);if (rc <=0 ) goto out;Signature · 1 line
2.31.1
Looks fine.
Reviewed-by Himanshu Madhani <[email protected]>
--
Himanshu Madhani Oracle Linux Engineering
Martin K. Petersen
AppliedLi,
Quoted 1 line
The
se_cmdis unused in these functions, just remove it.
Applied to 5.16/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 3 lines · Li Feng
The
se_cmdis unused in these functions, just remove it.
Applied to 5.16/scsi-queue, thanks!
[1/1] scsi: target: Remove unused argument of some functions
https://git.kernel.org/mkp/scsi/c/7e642ca0375b
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering