mpt3sas: Remove logging BIOS version in the kernel log
Subsystems (2)
Ranjan Kumar
maintainerPATCH 1/1 mpt3sas: Remove logging BIOS version in the kernel log
It is done to avoid ambiguity between BIOS and UEFI version. Management tools can be used for getting proper version information
--- drivers/scsi/mpt3sas/mpt3sas_base.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/scsi/mpt3sas/mpt3sas_base.c +2 -8
@@ -4761,21 +4761,15 @@ _base_display_ioc_capabilities(struct MPT3SAS_ADAPTER *ioc)int i =0 ;char desc[17 ] = {0 };u32 iounit_pg1_flags; -u32 bios_version; - bios_version =le32_to_cpu (ioc->bios_pg3.BiosVersion);strncpy (desc, ioc->manu_pg0.ChipName,16 ); -ioc_info (ioc,"%s: FWVersion(%02d.%02d.%02d.%02d), ChipRevision(0x%02x), BiosVersion(%02d.%02d.%02d.%02d)\n" , +ioc_info (ioc,"%s: FWVersion(%02d.%02d.%02d.%02d), ChipRevision(0x%02x)\n" , desc, (ioc->facts.FWVersion.Word &0xFF000000 ) >>24 , (ioc->facts.FWVersion.Word &0x00FF0000 ) >>16 , (ioc->facts.FWVersion.Word &0x0000FF00 ) >>8 , ioc->facts.FWVersion.Word &0x000000FF , - ioc->pdev->revision, - (bios_version &0xFF000000 ) >>24 , - (bios_version &0x00FF0000 ) >>16 , - (bios_version &0x0000FF00 ) >>8 , - bios_version &0x000000FF ); + ioc->pdev->revision);_base_display_OEMs_branding (ioc);
Signature · 1 line
2.31.1
Hi Ranjan!
Quoted 2 lines
It is done to avoid ambiguity between BIOS and UEFI version. Management tools can be used for getting proper version information
Not everyone uses management tools. Why not print the UEFI version as well?
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Sathya Prakash Veerichetty
maintainerMartin,
The only proper way to print UEFI Boot Services Driver version and legacy x86 OpROM version is to upload those image headers from flash and retrieve the version, various generation of the controllers have various type of image headers hence a good amount of code needs to be added to the driver to display them properly and associated feature maintenance, so we thought it is better to push that to applications space, if you think the added code is worth the value it provides, we can add it in the future, we would prefer to remove the current way of showing a version in that message.
Thanks
Sathya
Quoted 12 lines · Martin K. Petersen
Hi Ranjan!
Quoted 2 lines
It is done to avoid ambiguity between BIOS and UEFI version. Management tools can be used for getting proper version information
Not everyone uses management tools. Why not print the UEFI version as well?
--
Martin K. Petersen Oracle Linux Engineering
Signature · 11 lines
This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
Sathya,
Quoted 7 lines
The only proper way to print UEFI Boot Services Driver version and legacy x86 OpROM version is to upload those image headers from flash and retrieve the version, various generation of the controllers have various type of image headers hence a good amount of code needs to be added to the driver to display them properly and associated feature maintenance, so we thought it is better to push that to applications space
OK. As long as the firmware version is printed, I guess we can live without the legacy BIOS.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 4 lines · Ranjan Kumar
It is done to avoid ambiguity between BIOS and UEFI version. Management tools can be used for getting proper version information
Applied to 6.4/scsi-queue, thanks!
[1/1] mpt3sas: Remove logging BIOS version in the kernel log
https://git.kernel.org/mkp/scsi/c/3fc5d6d6dcac
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering