Skip to contentSkip to conversation

scsi: qedf: remove unused num_handled variable

PATCH Applied Tom Rix 2 participants 3 messages Mar 30, 2023 – Apr 12, 2023

Subsystems (2)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 scsi: qedf: remove unused num_handled variable

clang with W=1 reports drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
'num_handled' set but not used [-Werror,-Wunused-but-set-variable]

        int num_handled = 0;
            ^

This variable is not used so remove it.

---
 drivers/scsi/qedf/qedf_main.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/qedf/qedf_main.c +0 -2
index e7f2560b9f7d..3b64de81ea0d 100644
@@ -2224,7 +2224,6 @@ static bool qedf_process_completions(struct qedf_fastpath *fp)
 	u16 prod_idx;
 	struct fcoe_cqe *cqe;
 	struct qedf_io_work *io_work;
-	int num_handled = 0;
 	unsigned int cpu;
 	struct qedf_ioreq *io_req = NULL;
 	u16 xid;
@@ -2247,7 +2246,6 @@ static bool qedf_process_completions(struct qedf_fastpath *fp)
 
 	while (new_cqes) {
 		fp->completions++;
-		num_handled++;
 		cqe = &que->cq[que->cq_cons_idx];
 
 		comp_type = (cqe->cqe_data >> FCOE_CQE_CQE_TYPE_SHIFT) &
Signature · 1 line
2.27.0
#1 lore raw

Tom,

Quoted 6 lines

clang with W=1 reports drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
'num_handled' set but not used [-Werror,-Wunused-but-set-variable]

        int num_handled = 0;
            ^

This variable is not used so remove it.

Applied to 6.4/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Tom Rix
Quoted 8 lines · Tom Rix

clang with W=1 reports drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
'num_handled' set but not used [-Werror,-Wunused-but-set-variable]

        int num_handled = 0;
            ^

This variable is not used so remove it.

[...]

Applied to 6.4/scsi-queue, thanks!

[1/1] scsi: qedf: remove unused num_handled variable

      https://git.kernel.org/mkp/scsi/c/7866e03b9825
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering