scsi: libcxgbi: fix NULL pointer dereference in cxgbi_device_destroy()
PATCH 1/1 scsi: libcxgbi: fix NULL pointer dereference in cxgbi_device_destroy()
If cxgb4i_ddp_init() fails then cdev->cdev2ppm will be NULL, so add a check for NULL pointer before dereferencing it.
Signed-off-by Varun Prakash <[email protected]>
--- drivers/scsi/cxgbi/libcxgbi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/cxgbi/libcxgbi.c +2 -1
@@ -121,7 +121,8 @@ static inline void cxgbi_device_destroy(struct cxgbi_device *cdev) "cdev 0x%p, p# %u.\n", cdev, cdev->nports);cxgbi_hbas_remove (cdev);cxgbi_device_portmap_cleanup (cdev); -cxgbi_ppm_release (cdev->cdev2ppm (cdev)); +if (cdev->cdev2ppm) +cxgbi_ppm_release (cdev->cdev2ppm (cdev));if (cdev->pmap.max_connect)cxgbi_free_big_mem (cdev->pmap.port_csk);kfree (cdev);
Signature · 1 line
2.0.2
Martin K. Petersen
AppliedVarun,
Quoted 2 lines
If
cxgb4i_ddp_init()fails thencdev->cdev2ppmwill be NULL, so add a check for NULL pointer before dereferencing it.
Applied to 5.5/scsi-fixes, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering