Skip to contentSkip to conversation

scsi: lpfc: silence an incorrect device output

PATCH Applied Jun Chen 3 participants 3 messages Apr 10, 2023 – Apr 12, 2023

Subsystems (2)
lore
Share & tools
lore

Jun Chen

author
#0 lore raw

PATCH 1/1 scsi: lpfc: silence an incorrect device output

In lpfc_sli4_pci_mem_unset, case LPFC_SLI_INTF_IF_TYPE_1 does not have a break statement, resulting in an incorrect device output.

Fix this by adding a break statement before the default option.

---
 drivers/scsi/lpfc/lpfc_init.c | 1 +
 1 file changed, 1 insertion(+)
drivers/scsi/lpfc/lpfc_init.c +1 -0
index d062220d3232..da3a45441639 100644
@@ -12105,6 +12105,7 @@ lpfc_sli4_pci_mem_unset(struct lpfc_hba *phba)
 			iounmap(phba->sli4_hba.dpp_regs_memmap_p);
 		break;
 	case LPFC_SLI_INTF_IF_TYPE_1:
+		break;
 	default:
 		dev_printk(KERN_ERR, &phba->pcidev->dev,
 			   "FATAL - unsupported SLI4 interface type - %d\n",
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Jun,

Broadcom no longer supports LPFC_SLI_INTF_IF_TYPE_1 adapters, but the patch looks fine.

Thanks,
Justin

Quoted 27 lines · Jun Chen

In lpfc_sli4_pci_mem_unset, case LPFC_SLI_INTF_IF_TYPE_1 does not have a break statement, resulting in an incorrect device output.

Fix this by adding a break statement before the default option.

---
 drivers/scsi/lpfc/lpfc_init.c | 1 +
 1 file changed, 1 insertion(+)
drivers/scsi/lpfc/lpfc_init.c +1 -1
index d062220d3232..da3a45441639 100644
@@ -12105,6 +12105,7 @@ lpfc_sli4_pci_mem_unset(struct lpfc_hba *phba)
                        iounmap(phba->sli4_hba.dpp_regs_memmap_p);
                break;
        case LPFC_SLI_INTF_IF_TYPE_1:
+               break;
        default:
                dev_printk(KERN_ERR, &phba->pcidev->dev,
                           "FATAL - unsupported SLI4 interface type - %d\n",
--

2.25.1

#2 lore raw
In reply to Jun Chen

Jun,

Quoted 2 lines

In lpfc_sli4_pci_mem_unset, case LPFC_SLI_INTF_IF_TYPE_1 does not have a break statement, resulting in an incorrect device output.

Applied to 6.4/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering