scsi: qla2xxx: remove setting of 'req' and 'rsp' parameter
Subsystems (2)
PATCH 1/1 scsi: qla2xxx: remove setting of 'req' and 'rsp' parameter
cppcheck reports
[drivers/scsi/qla2xxx/qla_mid.c:594]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [drivers/scsi/qla2xxx/qla_mid.c:620]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
The functions qla25xx_free_req_que and qla25xx_free_rsp_que are similar. They free a 'req' and a 'rsp' parameter respectively. The last statement of both functions is setting the parameter to NULL. This has no effect and can be removed.
--- drivers/scsi/qla2xxx/qla_mid.c | 2 -- 1 file changed, 2 deletions(-)
drivers/scsi/qla2xxx/qla_mid.c +0 -2
@@ -591,7 +591,6 @@ qla25xx_free_req_que(struct scsi_qla_host *vha, struct req_que *req) }kfree (req->outstanding_cmds);kfree (req); - req =NULL ; } static void
@@ -617,7 +616,6 @@ qla25xx_free_rsp_que(struct scsi_qla_host *vha, struct rsp_que *rsp)mutex_unlock (&ha->vport_lock); }kfree (rsp); - rsp =NULL ; }int
Signature · 1 line
2.27.0
Quoted 37 lines · Tom Rix
cppcheck reports
[drivers/scsi/qla2xxx/qla_mid.c:594]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [drivers/scsi/qla2xxx/qla_mid.c:620]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?The functions
qla25xx_free_req_queandqla25xx_free_rsp_queare similar. They free a 'req' and a 'rsp' parameter respectively. The last statement of both functions is setting the parameter to NULL. This has no effect and can be removed.Signed-off-by Tom Rix <[email protected]>---
drivers/scsi/qla2xxx/qla_mid.c| 2 --1 file changed, 2 deletions(-)drivers/scsi/qla2xxx/qla_mid.c +0
-1@@ -591,7 +591,6 @@ qla25xx_free_req_que(struct scsi_qla_host *vha, struct req_que *req) }kfree (req->outstanding_cmds);kfree (req); - req =NULL ; }static void
drivers/scsi/qla2xxx/qla_mid.c +0
-1@@ -617,7 +616,6 @@ qla25xx_free_rsp_que(struct scsi_qla_host *vha, struct rsp_que *rsp)mutex_unlock (&ha->vport_lock); }kfree (rsp); - rsp =NULL ; }
Quoted 4 lines
int
Signature · 1 line
2.27.0
--
Himanshu Madhani Oracle Linux Engineering
Martin K. Petersen
AppliedTom,
Quoted 4 lines
The functions
qla25xx_free_req_queandqla25xx_free_rsp_queare similar. They free a 'req' and a 'rsp' parameter respectively. The last statement of both functions is setting the parameter to NULL. This has no effect and can be removed.
Applied to 5.19/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering