Skip to contentSkip to conversation

scsi: ufs: Increase fDeviceInit poll frequency

PATCH Applied Bart Van Assche 3 participants 4 messages Apr 21, 2022 – May 4, 2022 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: Increase fDeviceInit poll frequency

From: Konstantin Vyshetsky <[email protected]>

UFS devices are expected to clear fDeviceInit flag in single digit milliseconds. Current values of 5 to 10 millisecond sleep add to increased latency during the initialization and resume path. This CL lowers the sleep range to 500 to 1000 microseconds.

---
 drivers/scsi/ufs/ufshcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/ufs/ufshcd.c +1 -1
index 3f9caafa91bf..ba9c7f9ec424 100644
@@ -4438,7 +4438,7 @@ static int ufshcd_complete_dev_init(struct ufs_hba *hba)
 					QUERY_FLAG_IDN_FDEVICEINIT, 0, &flag_res);
 		if (!flag_res)
 			break;
-		usleep_range(5000, 10000);
+		usleep_range(500, 1000);
 	} while (ktime_before(ktime_get(), timeout));
 
 	if (err) {
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines

From: Konstantin Vyshetsky <[email protected]>

UFS devices are expected to clear fDeviceInit flag in single digit milliseconds. Current values of 5 to 10 millisecond sleep add to increased latency during the initialization and resume path. This CL lowers the sleep range to 500 to 1000 microseconds.

#2 lore raw
In reply to Bart Van Assche

Bart,

Quoted 4 lines

UFS devices are expected to clear fDeviceInit flag in single digit milliseconds. Current values of 5 to 10 millisecond sleep add to increased latency during the initialization and resume path. This CL lowers the sleep range to 500 to 1000 microseconds.

Applied to 5.19/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#3 lore raw
In reply to Bart Van Assche
Quoted 8 lines · Bart Van Assche

From: Konstantin Vyshetsky <[email protected]>

UFS devices are expected to clear fDeviceInit flag in single digit milliseconds. Current values of 5 to 10 millisecond sleep add to increased latency during the initialization and resume path. This CL lowers the sleep range to 500 to 1000 microseconds.

[...]

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: ufs: Increase fDeviceInit poll frequency

      https://git.kernel.org/mkp/scsi/c/a4e6496fca3f
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering