scsi: qedi: fix build regression
Subsystems (2)
PATCH 1/1 scsi: qedi: fix build regression
A bugfix I did caused a build regression in some other randconfig builds in a rare combination of options:
In file included from drivers/scsi/qedi/qedi_fw.c:16:drivers/scsi/qedi/qedi_gbl.h:26:38: error: array type has incomplete element type 'struct qedi_debugfs_ops'
extern const struct qedi_debugfs_ops qedi_debugfs_ops[];
^~~~~~~~~~~~~~~~This removes the useless #ifdef around the declarations in qedi_dbg.h to make it always build.
--- drivers/scsi/qedi/qedi_dbg.h | 2 -- 1 file changed, 2 deletions(-)
drivers/scsi/qedi/qedi_dbg.h +0 -2
@@ -103,7 +103,6 @@ int qedi_create_sysfs_attr(struct Scsi_Host *shost,void qedi_remove_sysfs_attr (struct Scsi_Host *shost,struct sysfs_bin_attrs *iter); -#ifdef CONFIG_DEBUG_FS/* DebugFS related code */ struct qedi_list_of_funcs {char *oper_str;
@@ -139,6 +138,5 @@ void qedi_dbg_host_init(struct qedi_dbg_ctx *qedi,void qedi_dbg_host_exit (struct qedi_dbg_ctx *qedi);void qedi_dbg_init (char *drv_name);void qedi_dbg_exit (void ); -#endif /* CONFIG_DEBUG_FS */ #endif /* _QEDI_DBG_H_ */
Signature · 1 line
2.9.0
Martin K. Petersen
AppliedArnd,
Quoted 10 lines
A bugfix I did caused a build regression in some other randconfig builds in a rare combination of options:
In file included from
drivers/scsi/qedi/qedi_fw.c:16:drivers/scsi/qedi/qedi_gbl.h:26:38: error: array type has incomplete element type 'structqedi_debugfs_ops'extern const struct qedi_debugfs_ops qedi_debugfs_ops[]; ^~~~~~~~~~~~~~~~This removes the useless #ifdef around the declarations in
qedi_dbg.hto make it always build.
Applied to 4.17/scsi-queue. Thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering