Skip to contentSkip to conversation

scsi: ufs: Remove unneeded casts from void *

PATCH Applied Markus Fuchs 3 participants 3 messages Sep 28, 2022 – Oct 1, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: Remove unneeded casts from void *

The end_io_data member of the "struct request" type has type "void *", so no cast is necessary.

---
 drivers/ufs/core/ufshpb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ufs/core/ufshpb.c +2 -2
index a1a7a1175a5a..0ce5063bedc5 100644
@@ -615,14 +615,14 @@ static void ufshpb_activate_subregion(struct ufshpb_lu *hpb,
 
 static void ufshpb_umap_req_compl_fn(struct request *req, blk_status_t error)
 {
-	struct ufshpb_req *umap_req = (struct ufshpb_req *)req->end_io_data;
+	struct ufshpb_req *umap_req = req->end_io_data;
 
 	ufshpb_put_req(umap_req->hpb, umap_req);
 }
 
 static void ufshpb_map_req_compl_fn(struct request *req, blk_status_t error)
 {
-	struct ufshpb_req *map_req = (struct ufshpb_req *) req->end_io_data;
+	struct ufshpb_req *map_req = req->end_io_data;
 	struct ufshpb_lu *hpb = map_req->hpb;
 	struct ufshpb_subregion *srgn;
 	unsigned long flags;
Signature · 1 line
2.37.3
#2 lore raw
In reply to Markus Fuchs

Markus,

Quoted 2 lines

The end_io_data member of the "struct request" type has type "void *", so no cast is necessary.

Applied to 6.1/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering