scsi/mpt3sas: Use dma_pool_zalloc
Subsystems (2)
PATCH 1/1 scsi/mpt3sas: Use dma_pool_zalloc
Replaced dma_pool_alloc + memset with dma_pool_zalloc.
Signed-off-by Brajeswar Ghosh <[email protected]>
Signed-off-by Souptick Joarder <[email protected]>
--- drivers/scsi/mpt3sas/mpt3sas_base.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/scsi/mpt3sas/mpt3sas_base.c +2 -4
@@ -4516,7 +4516,7 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc, i =0 ; do { ioc->reply_post[i].reply_post_free = - dma_pool_alloc(ioc->reply_post_free_dma_pool, + dma_pool_zalloc(ioc->reply_post_free_dma_pool, GFP_KERNEL, &ioc->reply_post[i].reply_post_free_dma); if (!ioc->reply_post[i].reply_post_free) {
@@ -4525,7 +4525,6 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc, ioc->name); goto out; } -memset (ioc->reply_post[i].reply_post_free,0 , sz); dinitprintk(ioc, pr_info(MPT3SAS_FMT "reply post free pool (0x%p): depth(%d)," "element_size(%d), pool_size(%d kB)\n", ioc->name,
@@ -4852,14 +4851,13 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc, ioc->name); goto out; } - ioc->reply_free =dma_pool_alloc (ioc->reply_free_dma_pool,GFP_KERNEL , + ioc->reply_free =dma_pool_zalloc (ioc->reply_free_dma_pool,GFP_KERNEL , &ioc->reply_free_dma);if (!ioc->reply_free) {pr_err (MPT3SAS_FMT "reply_free pool: dma_pool_alloc failed\n" , ioc->name); goto out; } -memset (ioc->reply_free,0 , sz);dinitprintk (ioc,pr_info (MPT3SAS_FMT "reply_free pool(0x%p): " \"depth(%d), element_size(%d), pool_size(%d kB)\n" , ioc->name, ioc->reply_free, ioc->reply_free_queue_depth,4 , sz/1024 ));
Signature · 1 line
1.9.1
Quoted 5 lines · Souptick Joarder
Replaced
dma_pool_alloc+ memset withdma_pool_zalloc.Signed-off-by Brajeswar Ghosh <[email protected]>Signed-off-by Souptick Joarder <[email protected]>
Any comment on this patch ?
Quoted 44 lines
--- drivers/scsi/mpt3sas/mpt3sas_base.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/scsi/mpt3sas/mpt3sas_base.c +2
-5@@ -4516,7 +4516,7 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc, i =0 ; do { ioc->reply_post[i].reply_post_free = - dma_pool_alloc(ioc->reply_post_free_dma_pool, + dma_pool_zalloc(ioc->reply_post_free_dma_pool, GFP_KERNEL, &ioc->reply_post[i].reply_post_free_dma); if (!ioc->reply_post[i].reply_post_free) {@@ -4525,7 +4525,6 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc, ioc->name); goto out; } -memset (ioc->reply_post[i].reply_post_free,0 , sz); dinitprintk(ioc, pr_info(MPT3SAS_FMT "reply post free pool (0x%p): depth(%d)," "element_size(%d), pool_size(%d kB)\n", ioc->name,@@ -4852,14 +4851,13 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc, ioc->name); goto out; } - ioc->reply_free =dma_pool_alloc (ioc->reply_free_dma_pool,GFP_KERNEL , + ioc->reply_free =dma_pool_zalloc (ioc->reply_free_dma_pool,GFP_KERNEL , &ioc->reply_free_dma);if (!ioc->reply_free) {pr_err (MPT3SAS_FMT "reply_free pool: dma_pool_alloc failed\n" , ioc->name); goto out; } -memset (ioc->reply_free,0 , sz);dinitprintk (ioc,pr_info (MPT3SAS_FMT "reply_free pool(0x%p): " \"depth(%d), element_size(%d), pool_size(%d kB)\n" , ioc->name, ioc->reply_free, ioc->reply_free_queue_depth,4 , sz/1024 )); --1.9.1
Suganath Prabu Subramani
maintainerLooks good,
Please consider this patch as Acked-by: Suganath Prabu <[email protected]>
Thanks
Quoted 49 lines · Souptick Joarder
Replaced
dma_pool_alloc+ memset withdma_pool_zalloc.Signed-off-by Brajeswar Ghosh <[email protected]>Signed-off-by Souptick Joarder <[email protected]>--- drivers/scsi/mpt3sas/mpt3sas_base.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/scsi/mpt3sas/mpt3sas_base.c +2
-5@@ -4516,7 +4516,7 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc, i =0 ; do { ioc->reply_post[i].reply_post_free = - dma_pool_alloc(ioc->reply_post_free_dma_pool, + dma_pool_zalloc(ioc->reply_post_free_dma_pool, GFP_KERNEL, &ioc->reply_post[i].reply_post_free_dma); if (!ioc->reply_post[i].reply_post_free) {@@ -4525,7 +4525,6 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc, ioc->name); goto out; } -memset (ioc->reply_post[i].reply_post_free,0 , sz); dinitprintk(ioc, pr_info(MPT3SAS_FMT "reply post free pool (0x%p): depth(%d)," "element_size(%d), pool_size(%d kB)\n", ioc->name,@@ -4852,14 +4851,13 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc, ioc->name); goto out; } - ioc->reply_free =dma_pool_alloc (ioc->reply_free_dma_pool,GFP_KERNEL , + ioc->reply_free =dma_pool_zalloc (ioc->reply_free_dma_pool,GFP_KERNEL , &ioc->reply_free_dma);if (!ioc->reply_free) {pr_err (MPT3SAS_FMT "reply_free pool: dma_pool_alloc failed\n" , ioc->name); goto out; } -memset (ioc->reply_free,0 , sz);dinitprintk (ioc,pr_info (MPT3SAS_FMT "reply_free pool(0x%p): " \"depth(%d), element_size(%d), pool_size(%d kB)\n" , ioc->name, ioc->reply_free, ioc->reply_free_queue_depth,4 , sz/1024 )); --1.9.1
Martin K. Petersen
Acked-by Suganath PrabuSuganath,
Quoted 2 lines
Please consider this patch as Acked-by: Suganath Prabu <[email protected]>
Next time, please make sure to put
Acked-by Suganath Prabu <[email protected]>
on a line by itself. Otherwise patchwork won't pick up the tag.
Thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedSouptick,
Quoted 1 line
Replaced
dma_pool_alloc+ memset withdma_pool_zalloc.
Applied to 4.20/scsi-queue, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering