Skip to contentSkip to conversation

scsi/mpt3sas: Use dma_pool_zalloc

PATCH Applied Souptick Joarder 3 participants 5 messages Oct 2, 2018 – Oct 11, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi/mpt3sas: Use dma_pool_zalloc

Replaced dma_pool_alloc + memset with dma_pool_zalloc.

---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/scsi/mpt3sas/mpt3sas_base.c +2 -4
index 59d7844..d7ef671 100644
@@ -4516,7 +4516,7 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
 	i = 0;
 	do {
 		ioc->reply_post[i].reply_post_free =
-		    dma_pool_alloc(ioc->reply_post_free_dma_pool,
+		    dma_pool_zalloc(ioc->reply_post_free_dma_pool,
 		    GFP_KERNEL,
 		    &ioc->reply_post[i].reply_post_free_dma);
 		if (!ioc->reply_post[i].reply_post_free) {
@@ -4525,7 +4525,6 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
 			ioc->name);
 			goto out;
 		}
-		memset(ioc->reply_post[i].reply_post_free, 0, sz);
 		dinitprintk(ioc, pr_info(MPT3SAS_FMT
 		    "reply post free pool (0x%p): depth(%d),"
 		    "element_size(%d), pool_size(%d kB)\n", ioc->name,
@@ -4852,14 +4851,13 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
 			ioc->name);
 		goto out;
 	}
-	ioc->reply_free = dma_pool_alloc(ioc->reply_free_dma_pool, GFP_KERNEL,
+	ioc->reply_free = dma_pool_zalloc(ioc->reply_free_dma_pool, GFP_KERNEL,
 	    &ioc->reply_free_dma);
 	if (!ioc->reply_free) {
 		pr_err(MPT3SAS_FMT "reply_free pool: dma_pool_alloc failed\n",
 			ioc->name);
 		goto out;
 	}
-	memset(ioc->reply_free, 0, sz);
 	dinitprintk(ioc, pr_info(MPT3SAS_FMT "reply_free pool(0x%p): " \
 	    "depth(%d), element_size(%d), pool_size(%d kB)\n", ioc->name,
 	    ioc->reply_free, ioc->reply_free_queue_depth, 4, sz/1024));
Signature · 1 line
1.9.1
#1 lore raw
Quoted 5 lines · Souptick Joarder

Replaced dma_pool_alloc + memset with dma_pool_zalloc.

Any comment on this patch ?

Quoted 44 lines
---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/scsi/mpt3sas/mpt3sas_base.c +2 -5
index 59d7844..d7ef671 100644
@@ -4516,7 +4516,7 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
        i = 0;
        do {
                ioc->reply_post[i].reply_post_free =
-                   dma_pool_alloc(ioc->reply_post_free_dma_pool,
+                   dma_pool_zalloc(ioc->reply_post_free_dma_pool,
                    GFP_KERNEL,
                    &ioc->reply_post[i].reply_post_free_dma);
                if (!ioc->reply_post[i].reply_post_free) {
@@ -4525,7 +4525,6 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
                        ioc->name);
                        goto out;
                }
-               memset(ioc->reply_post[i].reply_post_free, 0, sz);
                dinitprintk(ioc, pr_info(MPT3SAS_FMT
                    "reply post free pool (0x%p): depth(%d),"
                    "element_size(%d), pool_size(%d kB)\n", ioc->name,
@@ -4852,14 +4851,13 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
                        ioc->name);
                goto out;
        }
-       ioc->reply_free = dma_pool_alloc(ioc->reply_free_dma_pool, GFP_KERNEL,
+       ioc->reply_free = dma_pool_zalloc(ioc->reply_free_dma_pool, GFP_KERNEL,
            &ioc->reply_free_dma);
        if (!ioc->reply_free) {
                pr_err(MPT3SAS_FMT "reply_free pool: dma_pool_alloc failed\n",
                        ioc->name);
                goto out;
        }
-       memset(ioc->reply_free, 0, sz);
        dinitprintk(ioc, pr_info(MPT3SAS_FMT "reply_free pool(0x%p): " \
            "depth(%d), element_size(%d), pool_size(%d kB)\n", ioc->name,
            ioc->reply_free, ioc->reply_free_queue_depth, 4, sz/1024));
--

1.9.1

#2 lore raw
In reply to Souptick Joarder

Looks good,
Please consider this patch as Acked-by: Suganath Prabu <[email protected]>

Thanks

Quoted 49 lines · Souptick Joarder

Replaced dma_pool_alloc + memset with dma_pool_zalloc.

---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/scsi/mpt3sas/mpt3sas_base.c +2 -5
index 59d7844..d7ef671 100644
@@ -4516,7 +4516,7 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
        i = 0;
        do {
                ioc->reply_post[i].reply_post_free =
-                   dma_pool_alloc(ioc->reply_post_free_dma_pool,
+                   dma_pool_zalloc(ioc->reply_post_free_dma_pool,
                    GFP_KERNEL,
                    &ioc->reply_post[i].reply_post_free_dma);
                if (!ioc->reply_post[i].reply_post_free) {
@@ -4525,7 +4525,6 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
                        ioc->name);
                        goto out;
                }
-               memset(ioc->reply_post[i].reply_post_free, 0, sz);
                dinitprintk(ioc, pr_info(MPT3SAS_FMT
                    "reply post free pool (0x%p): depth(%d),"
                    "element_size(%d), pool_size(%d kB)\n", ioc->name,
@@ -4852,14 +4851,13 @@ void mpt3sas_base_clear_st(struct MPT3SAS_ADAPTER *ioc,
                        ioc->name);
                goto out;
        }
-       ioc->reply_free = dma_pool_alloc(ioc->reply_free_dma_pool, GFP_KERNEL,
+       ioc->reply_free = dma_pool_zalloc(ioc->reply_free_dma_pool, GFP_KERNEL,
            &ioc->reply_free_dma);
        if (!ioc->reply_free) {
                pr_err(MPT3SAS_FMT "reply_free pool: dma_pool_alloc failed\n",
                        ioc->name);
                goto out;
        }
-       memset(ioc->reply_free, 0, sz);
        dinitprintk(ioc, pr_info(MPT3SAS_FMT "reply_free pool(0x%p): " \
            "depth(%d), element_size(%d), pool_size(%d kB)\n", ioc->name,
            ioc->reply_free, ioc->reply_free_queue_depth, 4, sz/1024));
--

1.9.1