Skip to contentSkip to conversation

scsi: qedf: properly update arguments position in function call

PATCH Applied Gustavo A. R. Silva 3 participants 4 messages May 3, 2017 – May 9, 2017

Subsystems (2)
SCSI QLogic QL41xxx FCoE driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 scsi: qedf: properly update arguments position in function call

Properly update the position of the arguments in function call.

Addresses-Coverity-ID: 1402010

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/scsi/qedf/qedf_els.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qedf/qedf_els.c +1 -1
index 59f3e5c..107ed2b 100644
@@ -106,7 +106,7 @@ static int qedf_initiate_els(struct qedf_rport *fcport, unsigned int op,
 	did = fcport->rdata->ids.port_id;
 	sid = fcport->sid;
 
-	__fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, sid, did,
+	__fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, did, sid,
 			   FC_TYPE_ELS, FC_FC_FIRST_SEQ | FC_FC_END_SEQ |
 			   FC_FC_SEQ_INIT, 0);
Signature · 1 line
2.5.0
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Gustavo A. R. Silva

Properly update the position of the arguments in function call.

Addresses-Coverity-ID: 1402010

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/scsi/qedf/qedf_els.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qedf/qedf_els.c +0 -0
index 59f3e5c..107ed2b 100644

drivers/scsi/qedf/qedf_els.c static int qedf_initiate_els(struct qedf_rport *fcport, unsigned int op, · line 112

Quoted 8 lines
drivers/scsi/qedf/qedf_els.c +1 -1
@@ -106,7 +106,7 @@ static int qedf_initiate_els(struct qedf_rport *fcport, unsigned int op,
 	did = fcport->rdata->ids.port_id;
 	sid = fcport->sid;
 
-	__fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, sid, did,
+	__fc_fill_fc_hdr(fc_hdr, FC_RCTL_ELS_REQ, did, sid,
 			   FC_TYPE_ELS, FC_FC_FIRST_SEQ | FC_FC_END_SEQ |
 			   FC_FC_SEQ_INIT, 0);

Thanks.

Acked-by Chad Dupuis <[email protected]>
author
#3 lore raw

Hi Martin,

Quoting "Martin K. Petersen" <[email protected]>:

Quoted 6 lines

Gustavo A.,

Quoted 1 line

Properly update the position of the arguments in function call.

Applied to 4.12/scsi-fixes, thank you!

Awesome, glad to help. :)
--
Gustavo A. R. Silva