sched/core: Test online status in available_idle_cpu()
Sven Schnelle
reviewerPATCH 1/1 sched/core: Test online status in available_idle_cpu()
The current implementation of available_idle_cpu() doesn't test whether a possible cpu is offline. On s390 this dereferences a NULL pointer in arch_vcpu_is_preempted() because lowcore is not allocated for offline cpus. On x86, tracing also shows calls to available_idle_cpu() after a cpu is disabled, but it looks like this isn't causing any (obvious) issue. Nevertheless, add a check and return early if the cpu isn't online.
--- kernel/sched/core.c | 3 +++ 1 file changed, 3 insertions(+)
kernel/sched/core.c +3 -0
@@ -7434,6 +7434,9 @@ int idle_cpu(int cpu)*/ int available_idle_cpu (int cpu) { +if (!cpu_online (cpu)) +return 0 ; +if (!idle_cpu (cpu))return 0 ;
Signature · 1 line
2.40.1
Quoted 9 lines · Sven Schnelle
The current implementation of
available_idle_cpu()doesn't test whether a possible cpu is offline. On s390 this dereferences a NULL pointer inarch_vcpu_is_preempted()because lowcore is not allocated for offline cpus. On x86, tracing also shows calls toavailable_idle_cpu()after a cpu is disabled, but it looks like this isn't causing any (obvious) issue. Nevertheless, add a check and return early if the cpu isn't online.Signed-off-by Sven Schnelle <[email protected]>
So most of the uses of that function is in wakeup task placement.
o find_idlest_cpu() works on the sched_domain spans, so shouldn't deal with offline CPUs.
o select_idle_sibling() may issue an available_idle_cpu(prev) with an offline previous, which would trigger your issue.
Currently, even if select_idle_sibling() picks an offline CPU, this will get corrected by select_fallback_rq() at the end of select_task_rq(). However, it would make sense to realize @prev isn't a suitable pick before making it to the fallback machinery, in which case your patch makes sense beyond just fixing s390.
Sven Schnelle
reviewerQuoted 18 lines · Valentin Schneider
Quoted 9 lines · Sven Schnelle
The current implementation of
available_idle_cpu()doesn't test whether a possible cpu is offline. On s390 this dereferences a NULL pointer inarch_vcpu_is_preempted()because lowcore is not allocated for offline cpus. On x86, tracing also shows calls toavailable_idle_cpu()after a cpu is disabled, but it looks like this isn't causing any (obvious) issue. Nevertheless, add a check and return early if the cpu isn't online.Signed-off-by Sven Schnelle <[email protected]>So most of the uses of that function is in wakeup task placement.
ofind_idlest_cpu()works on thesched_domainspans, so shouldn't deal with offline CPUs.
oselect_idle_sibling()may issue anavailable_idle_cpu(prev)with an offline previous, which would trigger your issue.
Quoted 7 lines
Currently, even if
select_idle_sibling()picks an offline CPU, this will get corrected byselect_fallback_rq()at the end ofselect_task_rq(). However, it would make sense to realize @prev isn't a suitable pick before making it to the fallback machinery, in which case your patch makes sense beyond just fixing s390.Reviewed-by Valentin Schneider <[email protected]>
Thanks for the review! Ingo/Peter, gentle ping, are you planning to take this patch?
Sven Schnelle
reviewerQuoted 28 lines · Sven Schnelle
Quoted 9 lines · Valentin Schneider
Quoted 8 lines · Sven Schnelle
The current implementation of
available_idle_cpu()doesn't test whether a possible cpu is offline. On s390 this dereferences a NULL pointer inarch_vcpu_is_preempted()because lowcore is not allocated for offline cpus. On x86, tracing also shows calls toavailable_idle_cpu()after a cpu is disabled, but it looks like this isn't causing any (obvious) issue. Nevertheless, add a check and return early if the cpu isn't online.Quoted 5 lines
Quoted 1 line
Signed-off-by Sven Schnelle <[email protected]>So most of the uses of that function is in wakeup task placement.
ofind_idlest_cpu()works on thesched_domainspans, so shouldn'tdeal with
Quoted 2 lines
offline CPUs.
oselect_idle_sibling()may issue anavailable_idle_cpu(prev)withan
Quoted 3 lines
offline previous, which would trigger your issue.
Currently, even if
select_idle_sibling()picks an offline CPU, thiswill
Quoted 2 lines
get corrected by
select_fallback_rq()at the end ofselect_task_rq(). However, it would make sense to realize @previsn't a
Quoted 1 line
suitable pick before making it to the fallback machinery, in which
Quoted 8 lines
case
Quoted 3 lines
your patch makes sense beyond just fixing s390.
Reviewed-by Valentin Schneider <[email protected]>Thanks for the review! Ingo/Peter, gentle ping, are you planning to take
this patch?
Ping?
Thanks,
Sven