Skip to contentSkip to conversation

remove warning for drivers/gpu/drm/i915/intel_ringbuffer.c

PATCH In review Harry Wei 2 participants 3 messages Jun 3, 2011 – Jun 4, 2011

Subsystems (2)
lore
Share & tools
lore

Harry Wei

author
#0 lore raw

PATCH 1/1 remove warning for drivers/gpu/drm/i915/intel_ringbuffer.c

From: Harry Wei <[email protected]>
When i compile kernel, it shows me two warnings
like below, so this patch can fix them.

[...]
CC [M] drivers/gpu/drm/i915/intel_dvo.o
CC [M] drivers/gpu/drm/i915/intel_ringbuffer.o drivers/gpu/drm/i915/intel_ringbuffer.c:603: warning: ���ring_get_irq��� defined but not used drivers/gpu/drm/i915/intel_ringbuffer.c:620: warning: ���ring_put_irq��� defined but not used CC [M] drivers/gpu/drm/i915/intel_overlay.o
CC [M] drivers/gpu/drm/i915/intel_opregion.o
[...]

drivers/gpu/drm/i915/intel_ringbuffer.c +0 -17
Index: prj/drivers/gpu/drm/i915/intel_ringbuffer.c
===================================================================
@@ -599,23 +599,6 @@
 	return 0;
 }
 
-static bool
-ring_get_irq(struct intel_ring_buffer *ring, u32 flag)
-{
-	struct drm_device *dev = ring->dev;
-	drm_i915_private_t *dev_priv = dev->dev_private;
-
-	if (!dev->irq_enabled)
-	       return false;
-
-	spin_lock(&ring->irq_lock);
-	if (ring->irq_refcount++ == 0)
-		ironlake_enable_irq(dev_priv, flag);
-	spin_unlock(&ring->irq_lock);
-
-	return true;
-}
-
 static void
 ring_put_irq(struct intel_ring_buffer *ring, u32 flag)
 {
#1 lore raw

On Fri, 3 Jun 2011 21:09:39 +0800, Harry Wei <[email protected]> wrote:

(process:18294): gmime-CRITICAL **: g_mime_stream_filter_add: assertion `GMIME_IS_FILTER (filter)' failed

Quoted 3 lines

From: Harry Wei <[email protected]>
When i compile kernel, it shows me two warnings
like below, so this patch can fix them.

This fix is already upstream; it wasn't included in the stable patch as it wasn't 'necessary' to fix the bug which is causing the warning (which ended up removing the last use of this function).

Signature · 1 line
[email protected]
author
#2 lore raw
Quoted 9 lines · Keith Packard
Quoted 3 lines · Harry Wei

From: Harry Wei <[email protected]>
When i compile kernel, it shows me two warnings
like below, so this patch can fix them.

This fix is already upstream; it wasn't included in the stable patch as it wasn't 'necessary' to fix the bug which is causing the warning (which ended up removing the last use of this function).

Hmmm..., i see.

Thanks
Harry Wei