drm: sun4i: hdmi: Fix inverted HPD result
Chen-Yu Tsai
maintainerPATCH 1/1 drm: sun4i: hdmi: Fix inverted HPD result
From: Chen-Yu Tsai <[email protected]>
When the extra HPD polling in sun4i_hdmi was removed, the result of HPD was accidentally inverted.
Fix this by inverting the check.
Fixes bda8eaa6dee7 ("drm: sun4i: hdmi: Remove extra HPD polling")
Signed-off-by Chen-Yu Tsai <[email protected]>
---
Sorry for the screw-up.
--- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +1 -1
@@ -260,7 +260,7 @@ sun4i_hdmi_connector_detect(struct drm_connector *connector, bool force)unsigned long reg; reg =readl (hdmi->base +SUN4I_HDMI_HPD_REG ); -if (reg &SUN4I_HDMI_HPD_HIGH ) { +if (!(reg &SUN4I_HDMI_HPD_HIGH )) {cec_phys_addr_invalidate (hdmi->cec_adap);return connector_status_disconnected; }
Signature · 1 line
2.27.0
Quoted 9 lines · Chen-Yu Tsai
From: Chen-Yu Tsai <[email protected]>
When the extra HPD polling in
sun4i_hdmiwas removed, the result of HPD was accidentally inverted.Fix this by inverting the check.
Fixes bda8eaa6dee7 ("drm: sun4i: hdmi: Remove extra HPD polling")Signed-off-by Chen-Yu Tsai <[email protected]>
Tested-by Mans Rullgard <[email protected]>
Quoted 24 lines
---
Sorry for the screw-up.
--- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +1
-1@@ -260,7 +260,7 @@ sun4i_hdmi_connector_detect(struct drm_connector *connector, bool force)unsigned long reg; reg =readl (hdmi->base +SUN4I_HDMI_HPD_REG ); -if (reg &SUN4I_HDMI_HPD_HIGH ) { +if (!(reg &SUN4I_HDMI_HPD_HIGH )) {cec_phys_addr_invalidate (hdmi->cec_adap);return connector_status_disconnected; }Signature · 1 line
2.27.0
Signature · 1 line
Måns Rullgård
Maxime Ripard
AppliedQuoted 9 lines · Chen-Yu Tsai
From: Chen-Yu Tsai <[email protected]>
When the extra HPD polling in
sun4i_hdmiwas removed, the result of HPD was accidentally inverted.Fix this by inverting the check.
Fixes bda8eaa6dee7 ("drm: sun4i: hdmi: Remove extra HPD polling")Signed-off-by Chen-Yu Tsai <[email protected]>
Applied, thanks!
Maxime