omap4: enable L2 prefetching
Subsystems (3)
PATCH 1/1 omap4: enable L2 prefetching
From: Mans Rullgard <[email protected]>
Enabling L2 prefetching improves performance as shown on Panda ES2.1 board with mem test, and it has measurable impact on performances. I think we should consider it, even though it damages "writes" a bit. (rebased to k.org)
Usually the prefetch is used at both levels together L1 + L2, however, to enable the CP15 prefetch engines, these are under security, and on GP devices, we cannot enable it(e.g. on PandaBoard). However, just enabling PL310 prefetch seems to provide performance improvement, as shown in the data below (from Ubuntu) and would be a great thing to pull in.
Measurement Data:
==
STOCK 10.10 WITHOUT PATCH
========================
~# ./memspeed
size 8388608 8192k 8M
offset 8388608, 0
buffers 0x2aaad000 0x2b2ad000
copy libc 133 MB/s copy Android v5 273 MB/s copy Android NEON 235 MB/s copy INT32 116 MB/s copy ASM ARM 187 MB/s copy ASM VLDM 64 204 MB/s copy ASM VLDM 128 173 MB/s copy ASM VLD1 216 MB/s read ASM ARM 286 MB/s read ASM VLDM 242 MB/s read ASM VLD1 286 MB/s write libc 1947 MB/s write ASM ARM 1943 MB/s write ASM VSTM 1942 MB/s write ASM VST1 1935 MB/s
10.10 + PATCH
=============
~# ./memspeed
size 8388608 8192k 8M
offset 8388608, 0
buffers 0x2ab17000 0x2b317000
copy libc 129 MB/s copy Android v5 256 MB/s copy Android NEON 356 MB/s copy INT32 127 MB/s copy ASM ARM 321 MB/s copy ASM VLDM 64 337 MB/s copy ASM VLDM 128 321 MB/s copy ASM VLD1 350 MB/s read ASM ARM 496 MB/s read ASM VLDM 470 MB/s read ASM VLD1 488 MB/s write libc 1701 MB/s write ASM ARM 1682 MB/s write ASM VSTM 1693 MB/s write ASM VST1 1681 MB/s
---
Original:
http://git.mansr.com/?p=linux-panda;a=commit;h=450b17993ba7c36cea3f2c746ae26c268563ee59
http://git.tif.ti.com/vstehle/kernel-ubuntu.git?a=shortlog;h=refs/heads/vincent/mans-patches
arch/arm/mach-omap2/omap4-common.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/omap4-common.c +5 -1
@@ -64,6 +64,10 @@ static int __init omap_l2_cache_init(void) l2cache_base =ioremap (OMAP44XX_L2CACHE_BASE ,SZ_4K );BUG_ON (!l2cache_base); +if (omap_rev () !=OMAP4430_REV_ES1_0 ) +omap_smc1 (0x109 ,0x7e470000 ); + +/* Enable PL310 L2 Cache controller */ omap_smc1 (0x102 ,0x1 );
@@ -75,7 +79,7 @@ static int __init omap_l2_cache_init(void)if (omap_rev () ==OMAP4430_REV_ES1_0 )l2x0_init (l2cache_base,0x0e050000 ,0xc0000fff );else -l2x0_init (l2cache_base,0x0e070000 ,0xc0000fff ); +l2x0_init (l2cache_base,0x7e470000 ,0xc0000fff );/* * Override default outer_cache.disable with a OMAP4
Signature · 1 line
1.6.3.3
Quoted 12 lines · Nishanth Menon
From: Mans Rullgard <[email protected]>
Enabling L2 prefetching improves performance as shown on Panda ES2.1 board with mem test, and it has measurable impact on performances. I think we should consider it, even though it damages "writes" a bit. (rebased to k.org)
Usually the prefetch is used at both levels together L1 + L2, however, to enable the CP15 prefetch engines, these are under security, and on GP devices, we cannot enable it(e.g. on PandaBoard). However, just enabling PL310 prefetch seems to provide performance improvement, as shown in the data below (from Ubuntu) and would be a great thing to pull in.
What this does is enable automatic next line prefetching. With this enabled, whenever the PL310 receives a cachable read request, it automatically prefetches the following cache line as well. A larger offset can be programmed in secure mode, but the TI ROM authors neglected to include this.
Testing with FFmpeg showed a speedup of 10% with this patch in some cases.
Signature · 7 lines
Måns Rullgård [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Tony Lindgren
maintainerPATCH 1/1 omap4: enable L2 prefetching
Quoted 15 lines · M?ns Rullg?rd
Quoted 12 lines · Nishanth Menon
From: Mans Rullgard <[email protected]>
Enabling L2 prefetching improves performance as shown on Panda ES2.1 board with mem test, and it has measurable impact on performances. I think we should consider it, even though it damages "writes" a bit. (rebased to k.org)
Usually the prefetch is used at both levels together L1 + L2, however, to enable the CP15 prefetch engines, these are under security, and on GP devices, we cannot enable it(e.g. on PandaBoard). However, just enabling PL310 prefetch seems to provide performance improvement, as shown in the data below (from Ubuntu) and would be a great thing to pull in.
Quoted 8 lines
What this does is enable automatic next line prefetching. With this enabled, whenever the PL310 receives a cachable read request, it automatically prefetches the following cache line as well. A larger offset can be programmed in secure mode, but the TI ROM authors neglected to include this.
Testing with FFmpeg showed a speedup of 10% with this patch in some cases.
M?ns and Nishant, care to repost this with the updated comments?
Regards,
Tony
PATCH 1/1 omap4: enable L2 prefetching
In reply to Nishanth MenonQuoted 12 lines · Nishanth Menon
From: Mans Rullgard <[email protected]>
Enabling L2 prefetching improves performance as shown on Panda ES2.1 board with mem test, and it has measurable impact on performances. I think we should consider it, even though it damages "writes" a bit. (rebased to k.org)
Usually the prefetch is used at both levels together L1 + L2, however, to enable the CP15 prefetch engines, these are under security, and on GP devices, we cannot enable it(e.g. on PandaBoard). However, just enabling PL310 prefetch seems to provide performance improvement, as shown in the data below (from Ubuntu) and would be a great thing to pull in.
[...]
Quoted 19 lines
arch/arm/mach-omap2/omap4-common.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)arch/arm/mach-omap2/omap4-common.c +2
-0@@ -64,6 +64,10 @@ static int __init omap_l2_cache_init(void) l2cache_base =ioremap (OMAP44XX_L2CACHE_BASE ,SZ_4K );BUG_ON (!l2cache_base); +if (omap_rev () !=OMAP4430_REV_ES1_0 ) +omap_smc1 (0x109 ,0x7e470000 );/* Enable PL310 L2 Cache controller */ omap_smc1 (0x102 ,0x1 );
arch/arm/mach-omap2/omap4-common.c static int __init omap_l2_cache_init(void) · line 85
Quoted 8 lines
arch/arm/mach-omap2/omap4-common.c +1
-1@@ -75,7 +79,7 @@ static int __init omap_l2_cache_init(void)if (omap_rev () ==OMAP4430_REV_ES1_0 )l2x0_init (l2cache_base,0x0e050000 ,0xc0000fff );else -l2x0_init (l2cache_base,0x0e070000 ,0xc0000fff ); +l2x0_init (l2cache_base,0x7e470000 ,0xc0000fff );/* * Override default outer_cache.disable with a OMAP4
Adding/updaing the in-code comments would be helpful as well.
The exiting use of all the hard-coded constants in this code is rather unreadable and would be much more readable with symbolic constants, and this change just continues the pattern.
Ideally, switching this code to use symbolic constants and then adding the new feature would be a cleaner approach.
Kevin
PATCH 1/1 omap4: enable L2 prefetching
Quoted 56 lines
-----Original Message-----
From: linux-omap-owner at vger.kernel.org [mailto:linux-omap- owner at vger.kernel.org] On Behalf Of Kevin Hilman
Sent: Wednesday, November 17, 2010 12:19 AM
To: Nishanth Menon
Cc: linux-omap; linux-arm; Mans Rullgard
Subject: Re: [PATCH] omap4: enable L2 prefetchingQuoted 12 lines · Nishanth Menon
From: Mans Rullgard <[email protected]>
Enabling L2 prefetching improves performance as shown on Panda ES2.1 board with mem test, and it has measurable impact on performances. I think we should consider it, even though it damages "writes" a bit. (rebased to k.org)
Usually the prefetch is used at both levels together L1 + L2, however, to enable the CP15 prefetch engines, these are under security, and on GP devices, we cannot enable it(e.g. on PandaBoard). However, just enabling PL310 prefetch seems to provide performance improvement, as shown in the data below (from Ubuntu) and would be a great thing to pull in.[...]
arch/arm/mach-
Quoted 4 lines
arch/arm/mach-omap2/omap4-common.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)arch/arm/mach- renamed from arch/arm/mach-omap2/omap4-common.c +0
-0
omap2/omap4-common.cQuoted 15 lines
index 2f89555..a5e6126 100644
arch/arm/mach-omap2/omap4-common.c +2
-0@@ -64,6 +64,10 @@ static int __init omap_l2_cache_init(void) l2cache_base =ioremap (OMAP44XX_L2CACHE_BASE ,SZ_4K );BUG_ON (!l2cache_base); +if (omap_rev () !=OMAP4430_REV_ES1_0 ) +omap_smc1 (0x109 ,0x7e470000 );/* Enable PL310 L2 Cache controller */ omap_smc1 (0x102 ,0x1 );arch/arm/mach-omap2/omap4-common.c static int __init omap_l2_cache_init(void) · line 85
Quoted 8 lines
arch/arm/mach-omap2/omap4-common.c +1
-1@@ -75,7 +79,7 @@ static int __init omap_l2_cache_init(void)if (omap_rev () ==OMAP4430_REV_ES1_0 )l2x0_init (l2cache_base,0x0e050000 ,0xc0000fff );else -l2x0_init (l2cache_base,0x0e070000 ,0xc0000fff ); +l2x0_init (l2cache_base,0x7e470000 ,0xc0000fff );/* * Override default outer_cache.disable with a OMAP4 Adding/updaing the in-code comments would be helpful as well.
Quoted 7 lines
The exiting use of all the hard-coded constants in this code is rather unreadable and would be much more readable with symbolic constants, and this change just continues the pattern.
Ideally, switching this code to use symbolic constants and then adding the new feature would be a cleaner approach.
I have cleaned up a code a bit based on the comments from Kevin and also updated change log in Man's patch. Also added couple of relevant patches as part of this series which I haven't posted yet.
Will post the series on the list soon
Regards,
Santosh