BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
PATCH 1/1 BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
Make it clear to a reader that the user of OMAP34XX macros in the (OMAP 3530-based) beagle config file is just fine.
---
i'll let dirk be the judge as to whether this is worth adding, or if
he'd prefer a different phrasing.
include/configs/omap3_beagle.h +3 -0
@@ -30,6 +30,9 @@/* * High Level Configuration Options +* +* Note that, although the BeagleBoard incorporates an OMAP 3530, +* it's currently still valid to use OMAP34XX preprocessor values. */ #define CONFIG_ARMCORTEXA8 1/* This is an ARM V7 CPU core */ #define CONFIG_OMAP 1/* in a TI OMAP core */
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday
========================================================================
PATCH 1/1 BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
Quoted 15 lines · Robert P. J. Day
Make it clear to a reader that the user of OMAP34XX macros in the (OMAP 3530-based) beagle config file is just fine.
Signed-off-by Robert P. J. Day <[email protected]>---
i'll let dirk be the judge as to whether this is worth adding, or if
he'd prefer a different phrasing.include/configs/omap3_beagle.h +0
-0
include/configs/omap3_beagle.h line 38
Quoted 9 lines
include/configs/omap3_beagle.h +3
-0@@ -30,6 +30,9 @@/* * High Level Configuration Options +* +* Note that, although the BeagleBoard incorporates an OMAP 3530, +* it's currently still valid to use OMAP34XX preprocessor values. */ #define CONFIG_ARMCORTEXA8 1/* This is an ARM V7 CPU core */ #define CONFIG_OMAP 1/* in a TI OMAP core */
Since 34xx and 35xx are in fact exactly the same silicon, saying it is "currently" valid seems a bit odd. This sort of implies a planned change.
Signature · 2 lines
M?ns Rullg?rd mans at mansr.com
PATCH 1/1 BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
2009/11/19 M?ns Rullg?rd <[email protected]>:
Quoted 18 lines
Quoted 16 lines · Robert P. J. Day
Make it clear to a reader that the user of OMAP34XX macros in the (OMAP 3530-based) beagle config file is just fine.
Signed-off-by Robert P. J. Day <[email protected]>---
? i'll let dirk be the judge as to whether this is worth adding, or if he'd prefer a different phrasing.
include/configs/omap3_beagle.h +0
-0@@ -30,6 +30,9 @@
Quoted 13 lines
Quoted 8 lines
?/*
? * High Level Configuration Options
+ *
+ * Note that, although the BeagleBoard incorporates an OMAP 3530,
+ * it's currently still valid to use OMAP34XX preprocessor values. ? */
?#defineCONFIG_ARMCORTEXA8? 1 ? ? ? /* This is an ARM V7 CPU core */ ?#defineCONFIG_OMAP? ? ? ? ?1 ? ? ? /* in a TI OMAP core */Since 34xx and 35xx are in fact exactly the same silicon, saying it is "currently" valid seems a bit odd. ?This sort of implies a planned change.
I agree - I do not think there are any such plans. NAK to the patch. Regards,
Nishanth Menon
PATCH 1/1 BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
Quoted 3 lines · Nishanth Menon
I agree - I do not think there are any such plans. NAK to the patch. Regards,
Nishanth Menon
fair enough. but i think a two-line comment is still useful for
people new to ARM who know the beagle is a 3530 and wonder why all the macros use 34XX.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday
========================================================================
PATCH 1/1 BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
Quoted 9 lines · Robert P. J. Day
Quoted 3 lines · Nishanth Menon
I agree - I do not think there are any such plans. NAK to the patch. Regards,
Nishanth Menonfair enough. but i think a two-line comment is still useful for
people new to ARM who know the beagle is a 3530 and wonder why all the macros use 34XX.
Not disagreeing about the comment as such, only about the wording.
Signature · 2 lines
M?ns Rullg?rd mans at mansr.com
PATCH 1/1 BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.
In reply to Måns RullgårdQuoted 18 lines · M?ns Rullg?rd
Quoted 16 lines · Robert P. J. Day
Make it clear to a reader that the user of OMAP34XX macros in the (OMAP 3530-based) beagle config file is just fine.
Signed-off-by Robert P. J. Day <[email protected]>---
i'll let dirk be the judge as to whether this is worth adding, or if
he'd prefer a different phrasing.include/configs/omap3_beagle.h +0
-0@@ -30,6 +30,9 @@
Quoted 12 lines
include/configs/omap3_beagle.h line 38
Quoted 8 lines
include/configs/omap3_beagle.h +3
-0/* * High Level Configuration Options +* +* Note that, although the BeagleBoard incorporates an OMAP 3530, +* it's currently still valid to use OMAP34XX preprocessor values. */ #define CONFIG_ARMCORTEXA8 1/* This is an ARM V7 CPU core */ #define CONFIG_OMAP 1/* in a TI OMAP core */ Since 34xx and 35xx are in fact exactly the same silicon, saying it is "currently" valid seems a bit odd. This sort of implies a planned change.
ok, i can rephrase that. i was working off of a post by dirk a
couple days ago where he seemed to be suggesting that the door was open for some divergence down the road, but maybe i just misread. will fix shortly.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday
========================================================================