Skip to contentSkip to conversation

PATCH: "Ok" -> "OK" in messages

PATCH Sean M. Burke 10 participants 15 messages May 28, 2005 – Jun 23, 2005

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

The English interjection "OK" is misspelled as "Ok" in a dozen messages in the Linux kernel. The following patch corrects those typos from "Ok" to "OK". It affects no comments or symbol-names -- and it stops me wanting to gnaw my fingers off every time I see "Ok, booting the kernel."!

("Okay" is an acceptable variant spelling of "OK". I chose "OK" over "Okay" for sake of concision.)

(I also fix three incidental nearby typoes in drivers/media/video/bttv-driver.c -- see at the end.)

arch/alpha/boot/bootp.c +1 -1
diff -uprN --exclude='*~*' linux-2.6.9.orig/arch/alpha/boot/bootp.c linux-2.6.9/arch/alpha/boot/bootp.c
@@ -100,7 +100,7 @@ pal_init(void)
 		(INIT_HWRPB->processor_offset + (unsigned long) INIT_HWRPB);
 	rev = percpu->pal_revision = percpu->palcode_avail[2];
 
-	srm_printk("Ok (rev %lx)\n", rev);
+	srm_printk("OK (rev %lx)\n", rev);
 
 	tbia(); /* do it directly in case we are SMP */
 }
arch/alpha/boot/main.c +2 -2
diff -uprN --exclude='*~*' linux-2.6.9.orig/arch/alpha/boot/main.c linux-2.6.9/arch/alpha/boot/main.c
@@ -97,7 +97,7 @@ pal_init(void)
 		(INIT_HWRPB->processor_offset + (unsigned long) INIT_HWRPB);
 	rev = percpu->pal_revision = percpu->palcode_avail[2];
 
-	srm_printk("Ok (rev %lx)\n", rev);
+	srm_printk("OK (rev %lx)\n", rev);
 
 	tbia(); /* do it directly in case we are SMP */
 }
@@ -183,7 +183,7 @@ void start_kernel(void)
 	envval[nbytes] = '\0';
 	strcpy((char*)ZERO_PGE, envval);
 
-	srm_printk(" Ok\nNow booting the kernel\n");
+	srm_printk(" OK\nNow booting the kernel\n");
 	runkernel();
 	for (i = 0 ; i < 0x100000000 ; i++)
 		/* nothing */;
arch/i386/boot/compressed/misc.c +1 -1
diff -uprN --exclude='*~*' linux-2.6.9.orig/arch/i386/boot/compressed/misc.c linux-2.6.9/arch/i386/boot/compressed/misc.c
@@ -376,7 +376,7 @@ asmlinkage int decompress_kernel(struct
 	makecrc();
 	putstr("Uncompressing Linux... ");
 	gunzip();
-	putstr("Ok, booting the kernel.\n");
+	putstr("OK, booting the kernel.\n");
 	if (high_loaded) close_output_buffer_if_we_run_high(mv);
 	return high_loaded;
 }
arch/i386/mm/init.c +1 -1
diff -uprN --exclude='*~*' linux-2.6.9.orig/arch/i386/mm/init.c linux-2.6.9/arch/i386/mm/init.c
@@ -541,7 +541,7 @@ void __init test_wp_bit(void)
 		panic("This kernel doesn't support CPU's with broken WP. Recompile it for a 386!");
 #endif
 	} else {
-		printk("Ok.\n");
+		printk("OK.\n");
 	}
 }
 
arch/m32r/boot/compressed/misc.c +1 -1
diff -uprN --exclude='*~*' linux-2.6.9.orig/arch/m32r/boot/compressed/misc.c linux-2.6.9/arch/m32r/boot/compressed/misc.c
@@ -218,6 +218,6 @@ long decompress_kernel(void)
 	makecrc();
 	puts("Uncompressing Linux... ");
 	gunzip();
-	puts("Ok, booting the kernel.\n");
+	puts("OK, booting the kernel.\n");
 	return bytes_out;
 }
arch/sh/boot/compressed/misc.c +1 -1
diff -uprN --exclude='*~*' linux-2.6.9.orig/arch/sh/boot/compressed/misc.c linux-2.6.9/arch/sh/boot/compressed/misc.c
@@ -236,5 +236,5 @@ void decompress_kernel(void)
 	makecrc();
 	puts("Uncompressing Linux... ");
 	gunzip();
-	puts("Ok, booting the kernel.\n");
+	puts("OK, booting the kernel.\n");
 }
arch/sh64/boot/compressed/misc.c +1 -1
diff -uprN --exclude='*~*' linux-2.6.9.orig/arch/sh64/boot/compressed/misc.c linux-2.6.9/arch/sh64/boot/compressed/misc.c
@@ -245,7 +245,7 @@ void decompress_kernel(void)
 	}
 #endif
 
-	puts("Ok, booting the kernel.\n");
+	puts("OK, booting the kernel.\n");
 
 	cache_control(CACHE_DISABLE);
 }
drivers/base/power/shutdown.c +1 -1
diff -uprN --exclude='*~*' linux-2.6.9.orig/drivers/base/power/shutdown.c linux-2.6.9/drivers/base/power/shutdown.c
@@ -55,7 +55,7 @@ void device_shutdown(void)
 	list_for_each_entry_reverse(dev, &devices_subsys.kset.list, kobj.entry) {
 		pr_debug("shutting down %s: ", dev->bus_id);
 		if (dev->driver && dev->driver->shutdown) {
-			pr_debug("Ok\n");
+			pr_debug("OK\n");
 			dev->driver->shutdown(dev);
 		} else
 			pr_debug("Ignored.\n");
drivers/media/video/bttv-driver.c +3 -3
diff -uprN --exclude='*~*' linux-2.6.9.orig/drivers/media/video/bttv-driver.c linux-2.6.9/drivers/media/video/bttv-driver.c
@@ -3228,14 +3228,14 @@ static void bttv_irq_debug_low_latency(s
 	       (unsigned long)rc);
 
 	if (0 == (btread(BT848_DSTATUS) & BT848_DSTATUS_HLOC)) {
-		printk("bttv%d: Oh, there (temporarely?) is no input signal. "
-		       "Ok, then this is harmless, don't worry ;)\n",
+		printk("bttv%d: Oh, there (temporarily?) is no input signal. "
+		       "OK, then this is harmless, don't worry ;)\n",
 		       btv->c.nr);
 		return;
 	}
 	printk("bttv%d: Uhm. Looks like we have unusual high IRQ latencies.\n",
 	       btv->c.nr);
-	printk("bttv%d: Lets try to catch the culpit red-handed ...\n",
+	printk("bttv%d: Let's try to catch the culprit red-handed ...\n",
 	       btv->c.nr);
 	dump_stack();
 }
#1 lore raw
Quoted 5 lines · Sean M. Burke

The English interjection "OK" is misspelled as "Ok" in a dozen messages in the Linux kernel. The following patch corrects those typos from "Ok" to "OK". It affects no comments or symbol-names -- and it stops me wanting to gnaw my fingers off every time I see "Ok, booting the kernel."!

If you're going to do that, you might as well fix 'Uncompressing Linux' to 'Decompressing Linux' too, and stop _me_ from being annoyed as well.

There's another error within the context of your patch too.

Signature · 1 line
dwmw2
#2 lore raw
Quoted 9 lines · David Woodhouse
Quoted 5 lines · Sean M. Burke

The English interjection "OK" is misspelled as "Ok" in a dozen messages in the Linux kernel. The following patch corrects those typos from "Ok" to "OK". It affects no comments or symbol-names -- and it stops me wanting to gnaw my fingers off every time I see "Ok, booting the kernel."!

If you're going to do that, you might as well fix 'Uncompressing Linux' to 'Decompressing Linux' too, and stop _me_ from being annoyed as well.

While we are at it, what about changing this string to something language-neutral, like this:

arch/i386/boot/compressed/misc.c +3 -2
diff -Naurdp a/arch/i386/boot/compressed/misc.c b/arch/i386/boot/compressed/misc.c
@@ -10,6 +10,7 @@
  */
 
 #include <linux/linkage.h>
+#include <linux/version.h>
 #include <linux/vmalloc.h>
 #include <linux/tty.h>
 #include <video/edid.h>
@@ -373,9 +374,9 @@ asmlinkage int decompress_kernel(struct 
 	else setup_output_buffer_if_we_run_high(mv);
 
 	makecrc();
-	putstr("Uncompressing Linux... ");
+	putstr("Linux " UTS_RELEASE);
 	gunzip();
-	putstr("Ok, booting the kernel.\n");
+	putstr("\n");
 	if (high_loaded) close_output_buffer_if_we_run_high(mv);
 	return high_loaded;
 }
Signature · 1 line
pozsy
#3 lore raw
Quoted 17 lines · � wrote:
Quoted 17 lines

While we are at it, what about changing this string to something language-neutral, like this:

diff -Naurdp a/arch/i386/boot/compressed/misc.c b/arch/i386/boot/compressed/misc.c

arch/i386/boot/compressed/misc.c +1 -0
@@ -10,6 +10,7 @@
  */
 
 #include <linux/linkage.h>
+#include <linux/version.h>
 #include <linux/vmalloc.h>
 #include <linux/tty.h>
 #include <video/edid.h>
@@ -373,9 +374,9 @@ asmlinkage int decompress_kernel(struct
 	else setup_output_buffer_if_we_run_high(mv);
 
Quoted 9 lines

arch/i386/boot/compressed/misc.c asmlinkage int decompress_kernel(struct · line 382

Quoted 9 lines
arch/i386/boot/compressed/misc.c +2 -2
 	makecrc();
-	putstr("Uncompressing Linux... ");
+	putstr("Linux " UTS_RELEASE);
 	gunzip();
-	putstr("Ok, booting the kernel.\n");
+	putstr("\n");
 	if (high_loaded) close_output_buffer_if_we_run_high(mv);
 	return high_loaded;
 }

Language neutrality is not a goal for kernel messages, that I'm aware of. I disagree with this change because it yields a net reduction in understanding what's going on during booting.

=============================
Tim Bird
Architecture Group Chair, CE Linux Forum
Senior Staff Engineer, Sony Electronics
=============================

#4 lore raw
Quoted 17 lines · Tim Bird
Quoted 17 lines
Quoted 17 lines

While we are at it, what about changing this string to something language-neutral, like this:

diff -Naurdp a/arch/i386/boot/compressed/misc.c b/arch/i386/boot/compressed/misc.c

arch/i386/boot/compressed/misc.c +1 -0
@@ -10,6 +10,7 @@
  */
 
 #include <linux/linkage.h>
+#include <linux/version.h>
 #include <linux/vmalloc.h>
 #include <linux/tty.h>
 #include <video/edid.h>
@@ -373,9 +374,9 @@ asmlinkage int decompress_kernel(struct
 	else setup_output_buffer_if_we_run_high(mv);
 
Quoted 13 lines
Quoted 9 lines

arch/i386/boot/compressed/misc.c asmlinkage int decompress_kernel(struct · line 382

Quoted 9 lines
arch/i386/boot/compressed/misc.c +2 -2
 	makecrc();
-	putstr("Uncompressing Linux... ");
+	putstr("Linux " UTS_RELEASE);
 	gunzip();
-	putstr("Ok, booting the kernel.\n");
+	putstr("\n");
 	if (high_loaded) close_output_buffer_if_we_run_high(mv);
 	return high_loaded;
 }

Language neutrality is not a goal for kernel messages, that I'm aware of.

Of course this is true, but I think this very one is an exception: this is the only one seen when booting with the "quiet" kernel option or using some shiny bootlogo patches, both of which is common practice among distribution-shipped kernels.

Quoted 3 lines

I disagree with this change because
it yields a net reduction in understanding what's going on during booting.

No, it does not yields any reduction. Only the strings itself are changed, not the time they are printed.
Besides, nobody is interested that actually an uncompress step is in progress, that just works. And, btw if it fails (the gunzip), it prints an error message anyway iirc.

Signature · 1 line
pozsy
#5 lore raw
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
arch/i386/boot/compressed/misc.c +2 -2
-	putstr("Uncompressing Linux... ");
+	putstr("Linux " UTS_RELEASE);
 	gunzip();
-	putstr("Ok, booting the kernel.\n");
+	putstr("\n");
Quoted 8 lines · � wrote:
Quoted 2 lines

Language neutrality is not a goal for kernel messages, that I'm aware of.

Of course this is true, but I think this very one is an exception: this is the only one seen when booting with the "quiet" kernel option or using some shiny bootlogo patches, both of which is common practice among distribution-shipped kernels.

OK, I understand why this one might worth different consideration.

Quoted 7 lines
Quoted 4 lines

I disagree with this change because
it yields a net reduction in understanding what's going on during booting.

No, it does not yields any reduction. Only the strings itself are changed, not the time they are printed.

This is only true if the words themselves have no meaning or utility. They do.

Quoted 2 lines

Besides, nobody is interested that actually an uncompress step is in progress, that just works.

This is not true, a developer working on a new board support package cares whether we're in the decompress step or in the kernel booting step.

New developers unfamiliar with the kernel booting sequence will have to find out where this message is coming from, when things fail. Without a unique string to search for, this becomes quite difficult to find.

In my field, I work with a LOT of developers who are not deeply familiar with the kernel, but still face these bootup messages.

Quoted 2 lines

And, btw if it fails (the gunzip), it prints
an error message anyway iirc.

I'm not sure what happens on gunzip failure, but I see kernel boot failures quite often during board bringup, and it's nice to know if you've passed the decompression phase, etc. The messages you propose are much less instructive for the developer.

However, I will grant that we're not trying to
optimize for the developer, but rather should
be optimizing for the user. But if we can
do something that is suitable to both, I would
prefer it. Could we put just a little more
wording back in?

-- Tim

=============================
Tim Bird
Architecture Group Chair, CE Linux Forum
Senior Staff Engineer, Sony Electronics
=============================

#6 lore raw
In reply to Tim Bird
Quoted 4 lines · Tim Bird

Language neutrality is not a goal for kernel messages, that I'm aware of. I disagree with this change because it yields a net reduction in understanding what's going on during booting.

Just change the "Uncompressing" to "Decompressing". The other proposal of including the version is a good one as is correcting the "Ok". Whatever occurs porting the code into English can only be a good thing.

#7 lore raw
In reply to Sean M. Burke

There are another couple of mistakes near your fixes.

Quoted 1 line

panic("This kernel doesn't support CPU's with broken WP. Recompile it for a 386!");

"CPU's" should be "CPUs", without the apostrophe.

Quoted 1 line

printk("bttv%d: Uhm. Looks like we have unusual high IRQ latencies.\n",

"unusually high" rings better in my ears.

Signature · 2 lines
Måns Rullgård
[email protected]
#8 lore raw
Quoted 2 lines · Måns Rullgård

[..]
"unusually high" rings better in my ears.

It's an adjective not an adverb.

Matthias-Christian Ott

#9 lore raw
Quoted 4 lines · Matthias-Christian Ott
Quoted 2 lines · Måns Rullgård

[..]
"unusually high" rings better in my ears.

It's an adjective not an adverb.

It depends on how the sentence should be interpreted. Is it "unusual (high IRQ latencies)", or "(unusually high) IRQ latencies"?

Signature · 2 lines
Måns Rullgård
[email protected]
#10 lore raw
Quoted 9 lines · you
Quoted 5 lines · Matthias-Christian Ott
Quoted 2 lines · Måns Rullgård

[..]
"unusually high" rings better in my ears.

It's an adjective not an adverb.

It depends on how the sentence should be interpreted. Is it "unusual (high IRQ latencies)", or "(unusually high) IRQ latencies"?

You're right, it's "(unusually high) IRQ latencies". What we have now is grammatically incorrect.

Signature · 8 lines
Cheers,
Alistair.

personal:   alistair()devzero!co!uk
university: s0348365()sms!ed!ac!uk
student:    CS/CSim Undergraduate
contact:    1F2 55 South Clerk Street,
            Edinburgh. EH8 9PP.
#11 lore raw
In reply to Sean M. Burke

----- Original Message -----
From: "Sean M. Burke" <[email protected]>
To: <[email protected]>
Cc: <[email protected]>
Sent: Saturday, May 28, 2005 07:13
Subject: PATCH: "Ok" -> "OK" in messages

Quoted 5 lines

The English interjection "OK" is misspelled as "Ok" in a dozen messages in the Linux kernel. The following patch corrects those typos from "Ok" to "OK". It affects no comments or symbol-names -- and it stops me wanting to gnaw my fingers off every time I see "Ok, booting the kernel."!

That's not the most annoying IMO - see how many instances of something like this you'll sprinkled around:

printk("The PukeMaster is %sabled.\n", SomeFlag ? "dis" : "en");

If a NLS translator isn't a C programmer, they'll screw it up frequently.

#12 lore raw
Quoted 8 lines · <[email protected]> writes:
Quoted 5 lines · Sean M. Burke

The English interjection "OK" is misspelled as "Ok" in a dozen messages in the Linux kernel. The following patch corrects those typos from "Ok" to "OK". It affects no comments or symbol-names -- and it stops me wanting to gnaw my fingers off every time I see "Ok, booting the kernel."!

Quoted 6 lines

That's not the most annoying IMO - see how many instances of something like this you'll sprinkled around:

printk("The PukeMaster is %sabled.\n", SomeFlag ? "dis" : "en");

If a NLS translator isn't a C programmer, they'll screw it up frequently.

That's true, but the Linux kernel isn't subject to NLS translations.

Signature · 2 lines
Måns Rullgård
[email protected]
#14 lore raw

Worked many large scale multiple languages translation projects? I have. You take what you can get and make it as easy on them as possible to minimize your own grief.

----- Original Message -----
From: "Lee Revell" <[email protected]>
To: <[email protected]>
Cc: "Sean M. Burke" <[email protected]>; <[email protected]>; <[email protected]>
Sent: Saturday, May 28, 2005 17:02
Subject: Re: PATCH: "Ok" -> "OK" in messages

Quoted 4 lines · On Sat, 2005-05-28 at 09:14 -0400, [email protected] wrote:
Quoted 3 lines

printk("The PukeMaster is %sabled.\n", SomeFlag ? "dis" : "en");

If a NLS translator isn't a C programmer, they'll screw it up

frequently.

Quoted 6 lines

Then you need a better translator.

Lee