Skip to content

controllers/memcg: fixes for newer kernels

Joerg Vehlow ltp 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest0 of 3 patches 0 repliesNew

Patches in v2 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [LTP] [PATCH v2 0/3] controllers/memcg: fixes for newer kernels

Hi,

Quoted 7 lines · Li Wang

On Fri, Jun 25, 2021 at 3:31 AM Krzysztof Kozlowski <[email protected] <mailto:[email protected]>> wrote:

On 17/06/2021 09:07, Krzysztof Kozlowski wrote:

Quoted 7 lines

The patchset got positive LGTM on the Github. Any further comments for it or can it be applied?

I slightly agree with Richard that we need an explanation/investigation on where the 32*PAGE_SIZE comes from. Otherwise, we are very possible to mask a counter bug if only to make the test happy.

+1. I think it has something to do with batch processing of counter updates. The memory handling code is heavily batched per cpu and only committed to a global counter after the batch size overflows.
At least for the subgroup_charge test I once found that page table cache stored in kmem contributes to the memory counter used in the test. Maybe something in that region was changed in recent kernel version. Maybe you could ask on the kernel mailing list?

Quoted 2 lines

Forgive me pour cold water on the method though it looks good in coding:).

I would just suggest to make 32 * PAGESIZE a constant calculated in memcg_lib.sh, instead of calculating (and defining) it everywhere.

Quoted 5 lines
Signature · 3 lines
-- 
Regards,
Li Wang

J?rg