Skip to content

Fix for nvme-rdma host crash in nvmf-all.3

Steve Wise linux-nvme linux-rdma 1 version New

Get series with b4
b4 am '[email protected]'

Versions newest first

  1. v1 Latest0 of 1 patch 0 repliesNew

Patches in v1 No applies recorded yet

The patch the cover letter announces is not in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] Fix for nvme-rdma host crash in nvmf-all.3
Quoted 10 lines
Quoted 5 lines

This patch fixes a touch-after-free bug I discovered. It is against nvmf-all.3 branch of git://git.infradead.org/nvme-fabrics.git. The patch is kind of ugly, so any ideas on a cleaner solution are welcome.

Hey Steve, I don't see how this bug fixes the root-cause. Not exactly sure we understand the root-cause. Is it possible that this is a chelsio specific issue with send completion signaling (like we saw before)? Did this happen with a non-chelsio device?

Due to the stack trace, I believe this is a similar issue we saw before. It is probably chelsio-specific. I don't see it on mlx4.

The fix for the previous occurrence of this crash was to signal all FLUSH commands. Do you recall why that fixed it? Perhaps this failure path needs some other signaled command to force the pending unsignaled WRs to be marked "complete" by the driver?

Steve.