CPU hotplug support for Versatile platforms
Get series with b4
b4 am '006001cb5a7d$eaa69a70$bff3cf50$@[email protected]'Versions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] CPU hotplug support for Versatile platforms
Hi Rob,
Quoted 25 lines · Russell King - ARM Linux
Quoted 9 lines · Rob Herring
Quoted 7 lines
The platform specific SMP code is one area that prevents supporting a single kernel image. All the functions in
platsmp.cneed to be converted to function pointers and a lot of that code is pretty simliar across platforms. What's needed is a commonplatsmp.cwith something like platform specificsmp_opslike PowerPC. I think addressing that first would simplify this restructuring as you are doing some of what's needed, but you introducing new namespace problems like platform_cpu_*.Quoted 7 lines
The split between
smp.candplatsmp.cis there to allow different SMP implementations from the standard ARM Ltd SMP implementation (and there will be different implementations.)Just because all the SMP implementations that are currently merged are the standard ARM Ltd SMP implementation does not mean that we should move stuff out of
platsmp.cinto the generic code.Agreed, but the interface between
smp.candplatsmp.cdoes not allow for more than one SMP platform in a single image. Granted, there are plenty of other obstacles to multi-platform kernel binaries, but this one would be good to address before there are a bunch of SMP platforns rather than after. Ideally,platsmp.ccould be common, but optional for platforms that are significantly different.
Quoted 4 lines
The idea I have is add a
smp_initfunction ptr to struct mdesc which would fill in ansmp_opsstruct of function pointers and callset_cpu_possiblefor each core. This would replace the directsmp_init_cpuscall.
I think this is a separate patch. Whilst this sort of stuff is in the back of my mind when doing BSP stuff, it's not the primary concern of these patches. The platform_cpu_* namespace exists in the kernel already and is not something I have introduced [see mach-realview/hotplug.c].
The main aim of these patches is to allow multiple variants (core tiles) to exist for the versatile express without having to have separate machine IDs.
Cheers,
Will