Implement SMMU passthrough using the default domain
Get series with b4
b4 am '[email protected]'Versions newest first
- v1 Latest0 of 5 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] Implement SMMU passthrough using the default domain
Hi Will, Rob,
Quoted 58 lines
-----Original Message-----
From: linux-arm-kernel [mailto:linux-arm-kernel-bounces at lists.infradead.org] On Behalf Of Will Deacon
Sent: Thursday, February 02, 2017 9:41 PM
To: Sricharan <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org; 'Rob Clark' <[email protected]>; 'Joerg Roedel' <[email protected]>; iommu at lists.linux- foundation.org
Subject: Re: [PATCH 0/5] Implement SMMU passthrough using the default domainQuoted 49 lines · Sricharan
Hi Rob,
Quoted 30 lines
-----Original Message-----
From: linux-arm-kernel [mailto:linux-arm-kernel-bounces at lists.infradead.org] On Behalf Of Rob Clark
Sent: Thursday, February 02, 2017 8:33 PM
To: Joerg Roedel <[email protected]>
Cc: Will Deacon <[email protected]>; iommu at lists.linux-foundation.org; Sricharan <[email protected]>; linux-arm- kernel at lists.infradead.org
Subject: Re: [PATCH 0/5] Implement SMMU passthrough using the default domainQuoted 13 lines · Joerg Roedel
Quoted 11 lines · Sricharan
Thanks for this series. We had a case with the GPU.
The GPU's iommu was setup by kernel and the GPU
also does dynamic updates for on-the-fly switching between process pagetables. GPU driver was not using DMA domain and the GPU's firmware was always expecting to run out of contextbank
'0' (although not correct) , which was not the case after the DMA domain
was made default as '0' was getting allocated for DMA domain and there were concerns about reusing the DMA domain as well.
Now with this series, looks there is an way out of that that can be tried.So should the default domain not be per device specific selectable ?
Quoted 7 lines
Note that iommu-drivers can request direct-mapping for any given device on its initializtion. This is used on x86 for devices that need a 1-1 mapping for some reason.
Also device drivers can use the iommu-api and assign their own domain to a device, which allows them to manage the dma address space on their own.
Quoted 8 lines
Part of the problem is that
dev->archdata.dma_opsgets wired up toiommu_dma_ops. Which isn't so bad on it's own, except that cache ops are not exposed to drivers, forcing us to use dma-mapping API (dma_map_sg, etc) for cache operations.Possibly we should just expose cache op's to drivers bypass this abuse of dma-mapping.
[1], with this, when the default domain in not
DOMAIN_DMA, thendev->archdata.dma_opsis not set toiommu_dma_ops, instead remains to beswiotlb_ops. Is that not correct for gpu's unmanaged domain case ?https://www.spinics.net/lists/arm-kernel/msg556209.html
Quoted 2 lines
btw, Will, we definitely want this to *not* rely on kcmdline for the gpu with it's own private iommu case..
Quoted 8 lines
Quoted 2 lines
Ya, that changes behavior for all devices and some might want
DMA_DOMAINand some UNMANAGED.My patch changes the *default* domain. When would this ever be UNMANAGED?
If you're using an UNMANAGED domain, I think you need to take care of the DMA ops yourself. There are likely missing functions to do that, but they should be added in a separate series.
Sorry, i should have said DOMAIN_DMA or DOMAIN_IDENTITY is set as *default* domains from your patchset. So i have not tested this series yet. But the requirement that i thought for the gpu was
* a context bank (specially '0') should not be reserved for DOMAIN_DMA
* dma_ops should not be set to iommu_dma_ops for the gpu device.
I was seeing that both of that are satisfied in this series, if we choose IDENTITY_DOMAIN as default and later gpu attaches it own *UNMANAGED* domain.
The only thing i was thinking was, since we are changing the default domain for all device from command line, some device which require DOMAIN_DMA and some which require DOMAIN_IDENTITY as default was not possible.
Regards,
Sricharan